vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
36959 commits 1 branch 0 tags 587 MiB
Commit graph

353 commits

Author SHA1 Message Date
ChillarAnand
13b61f8a1d Merge branch 'develop' into none 2022-02-28 15:11:07 +05:30
Saqib Ansari
7ce128de6c Merge branch 'develop' of https://github.com/frappe/frappe into autocomplete-control 2022-02-25 15:49:13 +05:30
ChillarAnand
a079ea7957 Merge branch 'develop' into none 2022-02-25 11:26:09 +05:30
Revant Nandgaonkar
cdc6bcadb1
fix(cli): Database agnostic options for root db credentials (#15973) 
* fix(bench): new-site params for root db credentials

allow root credentials for postgresql
use common cli option name for both database types

* fix(bench): backward compatible db params

Co-authored-by: gavin <gavin18d@gmail.com>

* fix(bench): use common db cred params

use --db-root-username and --db-root-password

* feat(bench): add --set-default to bench new-site

* fix: do not set default root user

* fix: indentation

Co-authored-by: gavin <gavin18d@gmail.com>
 2022-02-25 09:58:59 +05:30
ChillarAnand
5ce3937d79 fix: Handle None filters in db query 2022-02-24 15:19:31 +05:30
Ankush Menat
2580561788
Merge pull request #16067 from cpdeethree/postgres-fix-table-creation 
fix: error in table creation from incorrect scope
 2022-02-22 12:36:57 +05:30
Ankush Menat
33890ed860 refactor: use f-strings instead of .format and % 2022-02-22 11:23:51 +05:30
cpdeethree
b2116ff36d fix: error in table creation from incorrect scope 2022-02-21 20:27:05 -06:00
barredterra
745297a49d refactor: a not in b 
Search: if not ([\w\d]*?) in ([\w\d]*?)
Replace: if $1 not in $2
 2022-02-21 19:54:34 +01:00
Saqib Ansari
9e6889fc6d Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-15 10:12:52 +05:30
Ankush Menat
c38d1f8a25
Merge pull request #15906 from ankush/ignore_duplicates_db 
feat(db/pg): ability to ignore pk collision
 2022-02-14 18:58:07 +05:30
Saqib Ansari
6b671af1ec Merge branch 'develop' into autocomplete-control 2022-02-14 12:29:23 +05:30
Suraj Shetty
abec0d8664
Merge branch 'develop' into link_title_refactor 2022-02-14 11:03:55 +05:30
Saqib Ansari
8f277a247e Merge branch 'develop' of https://github.com/frappe/frappe into autocomplete-control 2022-02-12 16:27:27 +05:30
Ankush Menat
1439e667b2 chore: add debug status temporarily 2022-02-09 16:25:39 +05:30
Saqib Ansari
6e0c4946f1 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-09 10:43:34 +05:30
Gavin D'souza
0482f1362a Merge branch 'develop' of github.com:frappe/frappe into dynamic-docfields 2022-02-08 16:50:58 +05:30
phot0n
a6ea0c9e37 fix: add index on parent in child table doctype 2022-02-07 17:49:37 +05:30
phot0n
266e1f95ed chore: adding back idx column 
This is needed for ordering in display of links as it keeps
track of the clicks on a particular link item
 2022-02-07 16:40:01 +05:30
phot0n
b31f3c24f6 refactor: remove parent, parenttype, parentfield, idx columns from non-child table doctypes 
* feat: add parent, parenttype, idx, parentfield columns to doctypes when transitioning from normal -> child table

* fix: remove parent, parenttype, parentfield, idx from DocType DocType
 2022-02-07 15:12:37 +05:30
Suraj Shetty
68d934ae0f
Merge branch 'develop' into link_title_refactor 2022-02-04 14:53:26 +05:30
mergify[bot]
819202f5da
Merge pull request #15560 from gavindsouza/set_value-refactor 
refactor: frappe.db.set_value
 2022-02-02 06:41:58 +00:00
Gavin D'souza
bd89a9de86 Merge branch 'develop' of github.com:frappe/frappe into dynamic-docfields 2022-02-01 18:14:58 +05:30
Gavin D'souza
66b09afda6 fix: Don't create DB column for Virtual DocFields 2022-02-01 17:48:02 +05:30
Saqib Ansari
bd8ac90286
fix(ux): show report button on too many writes error (#15614) 
* feat: log errors on too many writes to ease debugging

* fix(ux): extract and show which app/file/function caused too many writes

* fix: postgres error checking assumes exception is postgres exception

* fix: better default for skipping frames

Typically stack is like: some_app -> your_function -> this function. So last 2 frames need to be skipped.

* fix: postgres error checking assumes exception is postgres exception

* fix: better default for skipping frames

Typically stack is like: some_app -> your_function -> this function. So last 2 frames need to be skipped.

* refactor: show Report button instead of logging

* revert: unnecessary new functionality

* test: assert exact exception

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2022-01-31 18:57:32 +05:30
Saqib Ansari
51dcf8fd47 feat: add autocomplete option in custom fields 2022-01-29 19:16:03 +05:30
Saqib Ansari
a10a0dcf02 Merge branch 'develop' of https://github.com/frappe/frappe into autocomplete-control 2022-01-29 14:30:44 +05:30
Gavin D'souza
5b6ceb5543 Merge branch 'develop' of github.com:frappe/frappe into set_value-refactor 2022-01-28 18:39:12 +05:30
Ankush Menat
e5eca8232f
fix: dont auto drop manually created index on text types (#15739) 2022-01-26 17:47:30 +05:30
Suraj Shetty
75245c25dc
Merge pull request #15680 from surajshetty3416/fix-db-index 2022-01-25 11:16:47 +05:30
Saqib Ansari
10edae6524 feat: new autocomplete control 2022-01-24 17:21:15 +05:30
Ankush Menat
e58c557e12 fix: correctly compute doctype name from table name 2022-01-24 11:18:21 +05:30
Suraj Shetty
490b2f61cd chore: Add nosemgrep comment to avoid semgrep warnings 2022-01-24 11:00:18 +05:30
Suraj Shetty
9a5409892d fix(postgres): Create indexes while creating table 
Previously, indexes were not getting created based on "search_index" configuration while creating new table
 2022-01-24 10:26:38 +05:30
Suraj Shetty
47393bcb85 style: Fix formatting issues 2022-01-24 09:44:25 +05:30
Suraj Shetty
4d384f308b fix: Unique and Index constraints 2022-01-23 22:57:33 +05:30
Suraj Shetty
39031d18ed fix: Check if index exists with specific key_name 2022-01-23 17:44:07 +05:30
Suraj Shetty
c0fe37b94e fix: Sync "index" & "Unique" constraint changes in DB 2022-01-21 21:18:16 +05:30
Gavin D'souza
227dc26707 Merge branch 'develop' of github.com:frappe/frappe into set_value-refactor 2022-01-17 14:04:13 +05:30
Saqib Ansari
30ba577c0a Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-01-14 15:20:56 +05:30
Gavin D'souza
b64dc65088 fix: Set cache=True to maintain old behaviour consistency 2022-01-11 16:25:10 +05:30
Gavin D'souza
d81fe8699c feat: frappe.db.set_single_value 
Alias to frappe.db.set_value without having to pass the doctype name
twice or teh second one as None

Other changes:
* set/get db APIs for single DocTypes
* Make use of redundant cache key in frappe.db.get_single_value
 2022-01-10 21:03:14 +05:30
Gavin D'souza
479f637f76 fix(single:set_value): Cast using sbool instead of str for all 2022-01-10 20:59:50 +05:30
Gavin D'souza
3052808048 fix: Don't cast to str if None or Falsy 
* refactor: use get_single_value instead of set_value(blah, None, blah1)
* User.reload in test_home_page to combat what happens locally
 2022-01-10 15:05:57 +05:30
Saqib Ansari
06b00e8e01 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-01-07 16:01:44 +05:30
Gavin D'souza
123bcc9509 fix: Clear cache on set_value 2022-01-07 14:16:45 +05:30
Gavin D'souza
b0c30363cf fix: Cast values as str for all single doctypes 
Re-arranged block for simplicity. Type casting doesn't change anything
it seems. On get_value, values are casted properly.
 2022-01-07 11:49:49 +05:30
Gavin D'souza
697d6f2d7a fix: Run query even if no documents found for_update 
If no docnames are found, then use NULL as fallback. I tested this on PostgreSQL & MariaDB and it seems to work as expected

    In [1]: from frappe.query_builder import Field

    In [2]: frappe.db.set_value('ToDo', Field("creation") > Field("modified"), 'description', 'change 2', for_update=True, debug=True)
    SELECT "name" FROM "tabToDo" WHERE "creation">"modified"
    Execution time: 0.0 sec
    UPDATE "tabToDo" SET "description"='change 2',"modified"='2021-10-22 09:38:40.110481',"modified_by"='Administrator' WHERE "name" IN (NULL)
    Execution time: 0.0 sec
 2022-01-07 11:47:49 +05:30
Gavin D'souza
aefb8e3b06 fix: Expand iterable to get rid of extra brackets 
Although valid SQL, MariaDB didn't like double brackets on VALUES. It
raised ERROR 1241: Operand should contain 1 column(s)
 2022-01-07 11:46:56 +05:30
Gavin D'souza
44f603fc6e refactor: frappe.db.set_value 
* Simplified logic
* Perf enhancements (removed unnecessary conditional computations)
* Use query builder and ORM to build queries instead of juggling
 2022-01-07 11:45:27 +05:30