Commit graph

180 commits

Author SHA1 Message Date
Frappe Bot
e2729c65ea refactor: Delete Qunit test files
Since it is no longer used

(cherry picked from commit d30596b15e)
2021-04-28 03:46:23 +00:00
Andy Zhu
138c7841c2
fix: set_primary and set_primary_email bug (#12299)
* fix: set_primary and set_primary_email bug

When user untick the `is_primary_phone` or `is_primary_mobile` from the contact numbers table, we should reset the phone, mobile number etc.
Same goes for the email address table.

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.py

fix variable naming as suggested

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* test: Set empty string instead of none for number

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2021-03-10 05:02:50 +00:00
barredterra
3ad56b2d5f fix: fetch contacts in auto repeat 2021-02-03 15:46:00 +01:00
Suraj Shetty
b5d9c1e816 Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui 2020-11-06 10:42:37 +05:30
sezanzeb
ea6ebd396b chore: State/Province for Address 2020-10-21 16:18:01 +02:00
Shivam Mishra
9e39a7464a Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui 2020-10-21 11:55:13 +05:30
Abhishek Balam
e31162e9f1 fix: move get_shipping_address() from frappe to erpnext since it has no references 2020-10-14 21:10:16 +05:30
Abhishek Balam
37a3096b68 fix: remove serverside validation 2020-10-14 19:09:36 +05:30
Abhishek Balam
fb40044496 fix: moving 'is your company address' field to erpnext 2020-10-14 18:09:28 +05:30
Suraj Shetty
ba29d8d8b4 Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui 2020-10-01 13:10:37 +05:30
Wolfram Schmidt
a4c7eb9620
Update salutation.json (#11501)
Abbility to merge salutations after creation. Usefull when Mistakes are made like "Mrs." and "Mrs"

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
2020-09-21 15:04:08 +05:30
Suraj Shetty
7035eff6e3 Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui 2020-08-27 19:32:57 +05:30
prssanna
b33471c35a fix: replace darkgrey with darkgray 2020-08-27 15:44:37 +05:30
Afshan
ce161b37f8 fix: contact not showing in form 2020-08-26 22:32:46 +05:30
Suraj Shetty
21a0cafe62
fix: Validate and sanitise whitelisted search methods using decorator (#11197)
* fix: Validate and sanitize whitelisted search methods using decorator

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>

* refactor: Replace decorator name

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>

Co-authored-by: Prssanna Desai <prssud@gmail.com>
Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
2020-08-05 19:42:19 +05:30
Chinmay D. Pai
42daf5a905
chore: escape value and remove unused condition
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-20 19:05:43 +05:30
Chinmay D. Pai
28399ba94b
fix: check for searchfield in meta
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-16 15:41:29 +05:30
Chinmay D. Pai
1e6e305a37
fix: check if searchfield exists in default columns
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-16 15:36:07 +05:30
Chinmay D. Pai
907411d33f
fix: validate if field exists in meta before adding to query
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-16 15:33:04 +05:30
Suraj Shetty
0e1a8006ff
fix: Return empty array 2020-07-14 12:56:12 +05:30
Chinmay D. Pai
36d1b5f015
fix: check if field exists in meta before executing query
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-09 12:27:39 +05:30
Chinmay D. Pai
338151a7e5
fix: correctly format sql query
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-07 13:00:55 +05:30
Chinmay D. Pai
8ddfd2344d
chore: add search queries to whitelist
these functions are called through search widget and need to be
whitelisted to work

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-07-02 12:55:04 +05:30
Suraj Shetty
62661704d3
feat: Show phone icon if phone call handler is available (#10626) 2020-06-13 20:21:09 +05:30
Shivam Mishra
19e16d8a5a fix: TypeError in cmp 2020-05-16 20:08:38 +05:30
Rohit Waghchaure
ee0e4e0a44 fix: '>' not supported between instances of 'int' and 'NoneType' 2020-05-03 20:46:21 +05:30
Gavin D'souza
24e0174fcf fix: enable validations for email and phone data fields 2020-04-08 12:35:33 +05:30
Nabin Hait
006609f59e fix: Duplicate check before inserting in contcat email table 2020-03-30 19:34:36 +05:30
Deepesh Garg
05767310f8
fix: Preferred billing and shipping address selection (#9538)
* fix: Preferred billing and shipping address selection

* fix: Remove unnecessary code

* fix: looping

* fix: Cleaner function
2020-02-27 16:44:31 +05:30
Himanshu
52068ec0ca
fix: format error message (#9500)
* chore: format error message

* chore: formatting

* fix: remove / from translated string

* fix: typo

Co-authored-by: sahil28297 <37302950+sahil28297@users.noreply.github.com>
2020-02-19 15:53:46 +05:30
Himanshu
1353ef24b0
fix(Contact): Dont reroute from Contact to unrelated document (#9432)
* fix:dont reroute to doc if unrelated

* Update frappe/contacts/doctype/address/address.js

Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update frappe/contacts/doctype/contact/contact.js

Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* Update address.js

* Update contact.js

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-02-17 06:40:10 +00:00
Suraj Shetty
dee4a7336c fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
Marica
b1db148dc8 fix: More informational error message in Address. (#9352)
* fix: More informational error message in Address.

* fix: Changed message, added title.

* fix: Changes compatible with translations.

* fix: Translation fixes.

* style: Fix formatting

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-01-28 10:43:18 +00:00
deepeshgarg007
b4bff1d009 fix: Remove changes in notifications 2019-12-06 09:26:32 +05:30
deepeshgarg007
59d6be6446 fix: revert changes made to get_default_address function 2019-12-06 09:21:24 +05:30
deepeshgarg007
649759fc3f fix: Default and company address fixes 2019-11-29 14:56:37 +05:30
Gavin D'souza
57654d94aa fix(web-forms): view addresses only by session user 2019-11-20 12:53:52 +05:30
Himanshu Warekar
e1a7112d86 fix: test cases for contacts 2019-10-10 23:33:11 +05:30
Himanshu Warekar
2ace6739d7 fix: rename fields 2019-10-10 22:06:59 +05:30
Himanshu Warekar
ff1ef65e94 fix: rename filters for contact 2019-09-30 14:33:36 +05:30
Himanshu Warekar
89cfcd4bb2 fix: remove values if empty 2019-09-24 17:59:57 +05:30
Himanshu Warekar
85b518811d fix: add mandatory 2019-09-24 17:54:31 +05:30
Himanshu Warekar
770f56f4ce fix: set column width 2019-09-21 20:53:20 +05:30
Himanshu Warekar
7c075703a1 fix: codacy 2019-09-20 15:51:21 +05:30
Himanshu Warekar
cc8953ad66 tests: fix test cases 2019-09-20 14:00:40 +05:30
Himanshu Warekar
f3b7461498 fix: test fixes for same phone and mobile 2019-09-19 18:19:33 +05:30
Himanshu Warekar
5cda6d2d5a Merge branch 'develop' of https://github.com/frappe/frappe into con-fix 2019-09-19 15:39:45 +05:30
mergify[bot]
bde6d31dec
Merge pull request #8423 from hrwX/addr_query
feat(Contact): Show address related to doctype in child
2019-09-16 09:38:43 +00:00
Himanshu
25979febb6 fix: v11 patch breaking as v11 dint have gcontacts (#8426) 2019-09-16 12:02:06 +05:30
Himanshu Warekar
7dba556b8c test: fix test cases 2019-09-16 10:19:40 +05:30