Commit graph

647 commits

Author SHA1 Message Date
Ankush Menat
ee6743c26b
fix: avoid mutating list while iterating over it (#24438) 2024-01-18 05:44:30 +00:00
Ankush Menat
2b3ab02d79
Merge branch 'develop' into add-using-cached-build-flag 2024-01-18 10:51:04 +05:30
David Arnold
d87092936f
chore: simplify frappe.connect & require explicit site initialization 2024-01-17 16:53:30 +01:00
18alantom
9ece71bc56 feat: add using-cached flag to bench build
- add using-cache flag to node esbuild call

The flag is to be used by bench get-app if its is
using cache.

Flag causes building of assets to not run and
instead updates assets.json files from built assets.

Linking of assets in the sites folder also occurs.
2024-01-17 13:20:57 +05:30
Ankush Menat
307da3097f
Merge pull request #23329 from akhilnarang/allow-setting-db-username
refactor: allow setting a db user name different from the database name
2024-01-16 17:46:03 +05:30
Akhil Narang
265c0b0e01
fix(drop-site): set db root credentials in frappe.flags like how new-site is done
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
1e6eeba9b7
fix: add in missing logic, add in a test for creating a site with a specific user
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
c721fcf8c4
refactor: allow setting a db user name different from the database name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
David Arnold
4e7676806f
fix: undue error printing 2024-01-14 17:33:12 +01:00
Ankush Menat
64c7906b92 fix: regen single po file using --locale 2024-01-11 18:51:53 +05:30
Ankush Menat
9482126b93 perf: Skip rebuilding MO files where PO file is not updated 2024-01-10 17:04:34 +05:30
Ankush Menat
5d8208ccf4 feat: Build MO files with bench build
Translation assets are also... assets, so grouping them with `bench build`.

We can do some special function but that will likely require updating
bench for everyone. Not so ideal.

Also renamed `compile` function as it is a builtin in python.
2024-01-10 16:41:04 +05:30
Ankush Menat
9620a3c596 Merge branch 'develop' into po-translation 2024-01-10 16:17:47 +05:30
Akhil Narang
232da65e4c
fix(restore): check backup directory and bench directory if we can't find the file
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-05 15:42:31 +05:30
Ankush Menat
8a7707e3fa
fix(DX): store tracebacks with context (#24059) 2024-01-01 07:16:47 +00:00
Ankush Menat
78cd62fec0
chore: faster total rows estimation (#24058) 2024-01-01 07:09:36 +00:00
Ankush Menat
704043a2f8 chore: remove duplicate cache clearing
frappe.clear_cache removes everything
2023-12-28 19:00:03 +05:30
barredterra
483fa15c8f fix: clear translation cache
- Cache was not getting cleared, since it's user-specific
- Remove unused implementation from gettext
2023-12-26 23:17:31 +01:00
barredterra
d384bb4506 Merge remote-tracking branch 'upstream/develop' into po-translation 2023-12-26 16:45:05 +01:00
Akhil Narang
7f433b84af
feat: allow creating a backup with the older metadata style
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
a06e402f38
refactor: use a function with context manager for backup decryption
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
148efbc3ed
refactor(restore): adjust downgrade check
First actually check whether its a downgrade, then check for the force flag

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
50d21677b8
chore: drop use of magic library, run file command directly
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
2b7c74dd5e
feat(restore): handle encrypted backups better
Determine the mimetype based on the file contents instead of waiting for an exception
Cleaner + no need of duplicate code

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:09:08 +05:30
Akhil Narang
3b0f6de883
perf: don't extract backup files unless required
Read from the gzipped file wherever possible

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-26 11:08:48 +05:30
Ankush Menat
ca33deae12 fix: cast SQL booleans to python 2023-12-17 12:07:14 +05:30
Ankush Menat
40e48c9ac4
feat: describe-database-table to get stats about a table (#23813)
* feat: `describe-database-table` to get stats about a table

This provides description of table, indexes, total row count in machine
parseable format.

Towards https://github.com/frappe/press/issues/1265

* Update test_commands.py
2023-12-15 17:53:11 +05:30
Ankush Menat
b7c2989823
feat: add-database-index command to add and persist custom indexes (#23787) 2023-12-14 15:16:49 +00:00
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
91cebdace8 Merge branch 'develop' into po-translation 2023-12-02 19:43:32 +05:30
Akhil Narang
d67a6d168e
fix(commands/scheduler): typo (#23441)
* fix(commands/scheduler): typo

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* chore: Update frappe/commands/scheduler.py

[skip ci]

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-27 11:30:33 +05:30
Akhil Narang
d21c7730da
fix(commands/site): the old logic did rely on 0 evaluting to false
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:34:28 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
Drop redundant bool conversion

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Akhil Narang
ae9ae40bad
Merge pull request #23168 from blaggacao/refactor/centralize-python-shell-interface-for-database-binaries
refactor: give cli invocations of dbtools a dedicated interface
2023-11-17 17:02:41 +05:30
David Arnold
890becda33
fix: typo 2023-11-09 19:22:17 +01:00
David Arnold
b2f9ff09aa
feat(db): boostrap only option if resource management is exogenous
The database resource management including privileges granting can be
done by external secops. It can be undesirable to grant the grant option
to the framework user.

This commit implements the possibility to remove user resource
management from frappe entirely and only boostrap the database with its
target user.
2023-11-09 17:11:39 +01:00
David Arnold
40a2daf84c
chore: give cli invocations of dbtools a dedicated interface 2023-11-09 12:14:41 +01:00
barredterra
67404e0cd0 Merge branch 'develop' into po-translation 2023-11-06 19:40:25 +01:00
gavin
bedef22f34
fix(cli): Use mysql CLI as fallback is mariadb isnt found (#23004) 2023-10-30 19:48:04 +05:30
barredterra
e052fe651e fix: consistent naming migrate-csv-to-po 2023-10-29 01:31:27 +02:00
barredterra
403639999d feat: gettext bench commands 2023-10-15 20:28:43 +02:00
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql (#22620)
This has been done because the mysql command issues a deprecation warning now

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 12:49:16 +05:30
barredterra
ed2290d1d6 Merge branch 'develop' into feat/improve-openid-connect-devx 2023-10-07 15:22:59 +02:00
Suraj Shetty
80347c9f28
Merge branch 'develop' into update-cy-new 2023-09-25 14:53:23 +05:30
Gavin D'souza
b19c569761
fix(run-ui-tests): Set default browser as chrome
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-09-25 11:11:13 +05:30
Gavin D'souza
a5f709b468
ci: Use electron browser over chrome
* Electron is already shipped along with Cypress. Can we use it?
* Pass --record kwarg only if CYPRESS_RECORD_KEY envvar is set
2023-09-23 18:12:48 +05:30
Suraj Shetty
a496f6b5e1 build: Update cypress 2023-09-22 11:19:41 +05:30
Ankush Menat
56371f09e0 Revert "fix!: Bind development server only to localhost (#22397)"
This reverts commit 9244140816.

Breaks docker development installs
2023-09-20 11:43:56 +05:30
saif
8b83e051d0 refactor: Improve list_apps function readability and maintainability.
- Improve variable naming and reduce redundancy.
- Reorganize and simplify code structure.
2023-09-17 11:41:13 +03:00
David Arnold
64a09be958
Merge branch 'develop' into feat/improve-openid-connect-devx 2023-09-16 09:58:53 +02:00