David Arnold
e606c23823
Merge pull request #27697 from blaggacao/feat/notification-with-minutes-offset
...
feat/notification with minutes offset
2024-09-12 07:12:01 +02:00
Akhil Narang
2e28dc8735
chore: reword description
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-12 10:28:54 +05:30
David
924ddd07bd
fix: semgrep complaints
2024-09-12 02:13:46 +02:00
David
2a6161eea6
test: comment out due to uncontrollable side effects
2024-09-12 01:11:18 +02:00
David
43c5cbd8a6
feat(analytics): add basic utm nomenclature for analytics
2024-09-12 00:08:05 +02:00
David
dd8cd9860c
test: add more notification offset tests for edge cases
2024-09-10 20:11:59 +02:00
David (aider)
a8c53c8940
feat: Implement minutes_offset feature and add test cases
2024-09-10 16:45:53 +02:00
David
ac379f297c
fix: Add support for minutes-based notifications
2024-09-10 16:45:53 +02:00
David
6aa27c7d7a
fix: notification condition has no custom context (perf)
2024-09-10 16:37:19 +02:00
David
69ae0724ff
fix(notification): add ability to enqueue-call from server scripts
2024-09-03 20:46:17 +02:00
Balamurali M
cea1713575
fix(EmailQueue): Log more error onto email queue
...
Require it log actual exception raised by Email Delivery Service on plan
limit reached
2024-09-03 16:36:03 +05:30
Akhil Narang
cdfbbde3d5
Merge pull request #23691 from phot0n/fix-email-bulk-retry
...
refactor(minor): email retry
2024-08-28 16:54:48 +05:30
Akhil Narang
273545dcae
Merge pull request #27474 from akhilnarang/notify-email-queue-suspended
...
chore(email_queue): nudge user to resume email queue if suspended and they are manually sending
2024-08-22 12:12:15 +05:30
phot0n
082549e273
refactor: use the same method for retrying one as well as multiple email
...
queues
* removed retry_sending method from email queue controller
2024-08-22 05:56:00 +00:00
phot0n
c875fbe20a
refactor: email bulk retry
...
* move msgprint to frontend so that it cna be displayed before the api call is completed
* use set_value instead of save() doc method so that other doc values can't be altered
2024-08-22 05:55:59 +00:00
Akhil Narang
b4c53392d7
fix(notification): can't use message where it isn't defined
...
Sentry FRAPPE-7VT
Partial revert of 8a7707e3fa
```
UnboundLocalError: cannot access local variable 'message' where it is not associated with a value
File "frappe/app.py", line 114, in application
response = frappe.api.handle(request)
File "frappe/api/__init__.py", line 49, in handle
data = endpoint(**arguments)
File "frappe/api/v1.py", line 36, in handle_rpc_call
return frappe.handler.handle()
File "frappe/handler.py", line 49, in handle
data = execute_cmd(cmd)
File "frappe/handler.py", line 85, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "__init__.py", line 1768, in call
return fn(*args, **newargs)
File "frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
File "frappe/desk/form/save.py", line 37, in savedocs
doc.submit()
File "frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
File "frappe/model/document.py", line 1048, in submit
return self._submit()
File "frappe/model/document.py", line 1031, in _submit
return self.save()
File "frappe/model/document.py", line 337, in save
return self._save(*args, **kwargs)
File "frappe/model/document.py", line 390, in _save
self.run_post_save_methods()
File "frappe/model/document.py", line 1131, in run_post_save_methods
self.run_method("on_submit")
File "frappe/model/document.py", line 964, in run_method
self.run_notifications(method)
File "frappe/model/document.py", line 1024, in run_notifications
_evaluate_alert(alert)
File "frappe/model/document.py", line 1007, in _evaluate_alert
evaluate_alert(self, alert.name, alert.event)
File "frappe/email/doctype/notification/notification.py", line 517, in evaluate_alert
msg = f"<details><summary>{title}</summary>{message}</details>"
```
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 10:43:36 +05:30
Akhil Narang
7ab02055d6
chore(email_queue): nudge user to resume email queue if suspended and they are manually sending
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-21 16:21:52 +05:30
Suraj Shetty
5f9fdf2c0e
Merge branch 'develop' into f1007
2024-08-12 14:39:33 +05:30
Akhil Narang
fc12e46171
Merge pull request #27188 from blaggacao/chore/adapt-webhook-preview
...
chore: adapt webhook preview
2024-08-12 13:34:03 +05:30
David
ac0e46669d
fix: spec preview fields statically on the frontend
2024-08-09 13:50:41 +02:00
Akhil Narang
ae2ffa8c7e
fix(auto_email_report): ensure that a report is selected before we try to apply filters
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-06 12:38:29 +05:30
s-aga-r
b8e4f30e59
perf: use seperate endpoint to send newsletters ( #27268 )
2024-07-31 16:52:19 +05:30
ALB.Leach
dde466be3d
feat: Implement OAuth Backend App Flow for Email Accounts ( #27167 )
...
* feat: Implement OAuth Backend App Flow for Email Accounts
* chore: Reformat to satisfy linter
* chore: format
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-07-22 16:47:18 +05:30
Suraj Shetty
82fd0f012a
Merge pull request #26519 from blaggacao/feat/notification-preview
2024-07-22 16:39:02 +05:30
David
f3fce843c6
fix(notification): preview from standard notification
2024-07-18 18:55:29 +02:00
David
b2a3102345
feat(notifications): add preview
2024-07-18 18:55:25 +02:00
Akhil Narang
53b054e72e
Merge pull request #24725 from blaggacao/chore/generalize-notification-receiver-fields
...
feat: generalize receiver logic in notifications
2024-07-18 15:30:52 +05:30
David
4a4e25f988
style: format
2024-07-18 11:48:17 +02:00
Akhil Narang
3354fe9db4
fix(newsletter): prevent UnboundLocalError when doc is not associated with a value
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-07-18 11:36:15 +05:30
barredterra
eb28a7322b
fix(Email Account): handle errors during error handling
2024-07-17 13:20:09 +02:00
David
7c1abdf1aa
fix: implement feedback
2024-07-12 11:37:48 +02:00
David
c4da76579c
fix: error log context on notification failure
2024-07-12 11:37:47 +02:00
David
69ac3b7f16
fix: add customer to eligible indirections 2
2024-07-12 11:37:47 +02:00
David
f0a28b51ee
fix: add customer to eligible indirections
2024-07-12 11:37:47 +02:00
David Arnold
19e03592be
style: be more explicit and docstring
2024-07-12 11:37:46 +02:00
David Arnold
b00efb06c0
feat: generalize receiver logic in notifications
2024-07-12 11:37:42 +02:00
Sagar Vora
b193cde7c0
feat: allow creating Days Before / After notifications for child table ( #26982 )
2024-07-11 19:11:29 +05:30
Suraj Shetty
acd41b2d8c
Merge pull request #26797 from s-aga-r/fm-connector
...
feat: Frappe Mail Connector
2024-07-11 16:22:43 +05:30
Sumit Bhanushali
65375b0e4d
fix: inform user if email pull already running in queue
2024-07-11 11:47:57 +05:30
Sumit Bhanushali
5c1e0c2bc9
fix: freeze screen while pulling emails
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2024-07-11 11:31:33 +05:30
Sumit Bhanushali
928428c6a7
feat(Email): manually pull email from given email account
2024-07-10 12:36:51 +05:30
David
4a2e929f43
fix(notification): error message
2024-07-01 21:17:11 +02:00
barredterra
722807ee14
test: email with invalid encoding
2024-06-28 14:39:06 +02:00
s-aga-r
317ef25a3e
feat: use OAuth to login to Frappe Mail
2024-06-28 08:48:37 +05:30
barredterra
0a571e5ee4
fix(Unhandled Email): avoid crashing on invalid characters
2024-06-27 14:55:47 +02:00
s-aga-r
1ada5211b9
refactor: method to get frappe mail client instance
2024-06-24 06:16:55 +05:30
s-aga-r
2819a2d927
fix(ux): Email Account form
2024-06-22 08:55:02 +05:30
s-aga-r
5a4a36591e
fix: always use email id as sender
2024-06-20 16:30:12 +05:30
s-aga-r
fca0cf7b01
fix: validate Frappe Mail settings on Email Account save
2024-06-19 17:33:11 +05:30
s-aga-r
2f66425b1d
chore: provide last_synced_at while retrieving mails
2024-06-19 11:56:53 +05:30