Commit graph

1040 commits

Author SHA1 Message Date
tonspar
c12b753648
fix: make_request - prevents an error during response parsing if the response body is empty. (#24613)
* Update utils.py

Sometimes the returned response body is empty. This change prevents the error during frappe response parsing. For example DELETE request returns no content.

* Revert "Update utils.py"

This reverts commit edbfb6960a175da142e9114d8096e5f09665da1b.

* fix: Avoid parsing empty responses in make_request

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-02-10 08:50:22 +00:00
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
8a71054c0c
Merge pull request #24765 from ankush/black_to_ruff
ci: switch to ruff-format
2024-02-05 19:20:51 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
063e30964d fix: Use TEXT type for Webhook URLs to support large URLs 2024-02-05 17:50:04 +05:30
Ankush Menat
7487df22c9 refactor: use frappe.get_system_settings
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
David Arnold
b57dbe2dbc
Merge remote-tracking branch 'origin/develop' into chore/cleanup-frappe-connect-2 2024-01-30 10:47:19 +01:00
David Arnold
c57bc94ead
chore: cleanup frappe.connect invocations 2024-01-24 11:56:24 +01:00
Raffael Meyer
4cc89ae42b
Merge pull request #24500 from barredterra/fix-typos 2024-01-24 03:01:50 +01:00
barredterra
9d6cbd0c15 fix: typos 2024-01-24 02:41:03 +01:00
barredterra
bb7bb41621 fix: Google Drive translatability 2024-01-23 20:13:34 +01:00
Raffael Meyer
ed09885eb4
Merge pull request #24390 from barredterra/remove-redundant-drive-api-key 2024-01-16 14:08:23 +01:00
barredterra
c17f014ef4 refactor: remove redundant API Key from Google Picker 2024-01-16 13:26:03 +01:00
Akhil Narang
c721fcf8c4
refactor: allow setting a db user name different from the database name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Tanmoy Sarkar
a084f91e18
Merge branch 'frappe:develop' into integrate_frappe_notification 2024-01-08 16:52:27 +05:30
Ankush Menat
4e188ec531
fix: webhook error logging fails (#24172)
These variables can be unset if webhook fails while creating them.
2024-01-08 15:37:04 +05:30
Tanmoy Sarkar
896da0afb3 fix: fix issues 2024-01-04 18:36:54 +05:30
Tanmoy Sarkar
30726d364f chore: keep push notification relay disable by default 2024-01-04 12:16:07 +05:30
Tanmoy Sarkar
853a0c1f58 feat: add frappe notification client 2024-01-04 11:38:19 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Hussain Nagaria
24c8b0fb6c docs: make_*_request utils 2023-12-17 11:59:27 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
f0aaeadd49 fix: Correct fallback for social login key 2023-12-11 12:48:47 +05:30
Ankush Menat
e4a9431c9c
fix: change webhook header types to small text (#23722)
closes https://github.com/frappe/frappe/issues/18650
2023-12-11 06:30:01 +00:00
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
6cb425baae Revert "refactor: OAuth flow without breaking routing convention"
This reverts commit e96ecab00e.
2023-12-02 20:02:24 +05:30
Shariq Ansari
da385ccefe
Merge pull request #23537 from shariquerik/flaky-ui-test 2023-12-01 20:21:20 +05:30
Shariq Ansari
33f729ebd3 chore: linter fix 2023-12-01 20:03:18 +05:30
ruthra kumar
0a7c0593da refactor: execute the last instance of a webhook in a request 2023-12-01 15:15:43 +05:30
tonspar
fae3685b03
feat: Patch and Delete Request to integration utils (#23525)
* Update utils.py

Adding the patch and delete request

* Update safe_exec.py

Adding the patch and delete request from integration utils.
2023-12-01 10:25:43 +05:30
Sagar Vora
1490fc1ba6
perf: avoid double local caching webhooks (#23426)
### Changes Made

- remove cache in `frappe.flags` (and related comment)
- use cache generator
- ⚠️ micro optimisation: use a variable for `frappe.flags`
2023-11-29 03:10:04 +00:00
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow (#23369) 2023-11-23 13:21:27 +05:30
Ankush Menat
31e3b3f981
fix: social key signup without signup conf (#23359) 2023-11-22 11:32:45 +00:00
David Arnold
ec4bc971c5
fix(integration): preserver data json formatting on update 2023-11-07 16:43:13 +01:00
Hussain Nagaria
a46308709b fix: add params in make_request arguments 2023-11-01 17:30:58 +05:30
Ankush Menat
563639235e
Merge pull request #22300 from ankush/api_v2
feat!: API versioning and API v2 (beta)
2023-10-17 11:34:26 +05:30
Corentin Flr
2b542d87e1
fix: Fix scopes for Google Calendar (#22614)
https://developers.google.com/identity/protocols/oauth2/scopes
2023-10-17 08:07:38 +05:30
Ankush Menat
e96ecab00e refactor: OAuth flow without breaking routing convention
Appending `/connected-app` after method breaks routing.
2023-10-16 18:12:53 +05:30
Ankush Menat
275f16060a fix: route ambiguitities and / in name
v1 and v2:
- Use path convertor to consume entire document which MIGHT contain `/`
- Drop string convertor, as it's the default
- Dont merge slashes - avoid consuming something that's part of name

v2:
- `SI/BLAH/BLAH/submit` is not simple to parse without ambiguitity
- `SI/BLAH/BLAH/method/submit` removes ambiguitity for 99.99% cases.
2023-10-16 18:12:53 +05:30
Sagar Vora
258c175982 perf: defer db query when saving Event 2023-10-16 12:59:30 +05:30
Anand Chitipothu
aff3f66366
fix: work-around to fix issue with syncing Google Contacts (#22649)
Issue #22648
2023-10-16 12:29:49 +05:30
Ankush Menat
e1f2f4bb54 fix: Let social login key control signups
There are cases where certain social login keys

- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
2023-10-14 12:43:48 +05:30
Sagar Vora
6043909fe6 fix: allow larger URLs in Integration Request 2023-10-09 19:13:10 +05:30
David Arnold
086435c004
feat: add upstream json argument to integrations make_request (#22462)
* feat: add upstream json argument to integrations make_request

* style: format

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 13:15:22 +05:30
Corentin Flr
8882679357
fix: Ensure Google Calendar scopes is a List (#22333) 2023-09-11 18:04:22 +05:30
Ankush Menat
2f4c5c63aa test: fix ldap test 2023-08-29 12:07:58 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Shariq Ansari
9902f36812 fix: show full name instead of first/last name 2023-07-27 13:22:38 +05:30