Commit graph

134 commits

Author SHA1 Message Date
Ankush Menat
071e269548 fix!: Switch to creation as default sort order 2024-03-27 11:18:28 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Ankush Menat
4a81d9f8e3
feat!: populate fields from kwargs in frappe.new_doc (#21190)
This makes it similar to `get_doc` API BUT still signifies intent that
it's a "NEW" document.

Minor Breaking Change: positional arguments are now forcefully keyword
arguments. Only seems to be used internally from what I can tell.

https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/frappe/.*+/frappe.new_doc%5C%28.*%3F%2C.*%3F%5C%29/+lang:python+&patternType=regexp&case=yes&sm=0&groupBy=repo
2023-05-31 12:29:31 +05:30
Ankush Menat
e00023deb1 refactor: replace bad usage of db.set_value 2023-01-04 11:13:53 +05:30
Ankush Menat
f34f7030a3 refactor: remove txt param from generate_hash use 2022-11-10 11:56:48 +05:30
Ankush Menat
17d327719e build(deps): drop unused dependencies
- googlemaps
- google-auth-httplib2
- urllib3
- pypng
- pyasn1
- gitdb
2022-08-26 10:23:09 +05:30
phot0n
4b069374f5 chore: remove stripe patch 2022-07-26 23:17:05 +05:30
Ankush Menat
29c855b028
fix: db.get_value -> db.get_single_value (#17531)
db.get_value for singles returns string type always, this is confusing
behaviour, db.get_single_value should be used instead.

semgrep rule: https://github.com/frappe/semgrep-rules/pull/16
2022-07-18 15:10:49 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
214be6a7e8 chore: discard stale patches, add relevant ones to patches.txt 2022-06-16 14:10:01 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
barredterra
b1383df15a refactor: use is None instead of == None 2022-01-17 10:37:51 +01:00
Ankush Menat
e8e90d4320 fix: patch failure due to incorrect args in query 2021-10-26 11:40:19 +05:30
Aradhya-Tripathi
2c088c81ba refactor: Converted more queries 2021-10-15 05:00:46 +05:30
abhishek
b2b391e90a style: misc 2021-10-11 17:23:17 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
01d275f667 style: Format code for better readability
* Remove trailing whitespaces
* Format code to fit module conventions
* Add appropriate new lines between imports, classes, fn defs, etc
* Added comments, docstrings & module headers
2021-07-28 18:55:27 +05:30
Aradhya-Tripathi
84ff1d0af9 style: removed frappe.db.sql comments 2021-07-28 13:48:01 +05:30
Aradhya-Tripathi
8feb430371 refactor: Moved raw queries to frappe orm 2021-07-21 23:32:18 +05:30
Gavin D'souza
5aeef088ad fix: Remove reloading statements for non existing dts 2021-06-03 18:47:31 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Helkyd
09112389c2
fix(patch): reload_and_rename_view_log.py (#10890)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2020-07-03 11:12:44 +05:30
Sahil Khan
34d2357526 fix(patch): reload Prepared Report doctype 2020-01-15 13:18:52 +05:30
Chinmay D. Pai
deaa865fa8
fix(patch): auto commit on more than 10000 writes
fixes issue where patch fails with:

frappe.exceptions.ValidationError: Too many writes in one request. Please send smaller requests

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-10 09:16:37 +05:30
Rohit Waghchaure
86ecf4fbc1 fix: patch 2019-12-06 18:06:52 +05:30
Rohit Waghchaure
54e5538065 fix: patch 2019-12-06 15:18:54 +05:30
Aditya Hase
333ea79d2d
fix(patch): Handle failures in while making Prepared Report attachments private 2019-11-26 18:33:54 +05:30
Aditya Hase
17161976c6
fix(security): Make all Prepared Report file attachments private 2019-11-25 19:35:18 +05:30
mergify[bot]
849bbe1ca0
Merge pull request #8590 from sahil28297/fix_create_contact
fix(patch): check if contact already exists for user
2019-10-12 04:56:29 +00:00
Sahil Khan
106b7e995c fix(patch): reload prepared report doctype 2019-10-11 16:08:16 +05:30
Sahil Khan
30c6720398 fix(patch): check if contact already exists for user 2019-10-11 16:03:24 +05:30
Sahil Khan
e8e8aca4f7 fix(patch): reload Call Log 2019-10-03 13:15:40 +05:30
Nabin Hait
4668cc64e0 fix: reload google contacts 2019-09-16 12:49:03 +05:30
Himanshu Warekar
d96b08d9c8 fix: use meta instead of version 2019-09-02 21:53:00 +05:30
Suraj Shetty
7f618f6541 fix: Reload contact email and contact phone
Only reload  contact email and contact phone  if
version is greater than 11.
2019-09-02 15:25:57 +05:30
Suraj Shetty
50a1f1023f
fix: Use get_meta to avoid error 2019-05-30 15:16:09 +05:30
Suraj Shetty
9f798e2913 fix: UniqueFieldnameError while migration 2019-05-29 13:03:48 +05:30
Suraj Shetty
704b091c4c fix: Add a patch to apply customization to custom doctype (#7546)
This patch aims to apply & delete all the customization
on custom doctypes done through customize form

This is required because customize form in now blocked
for custom doctypes and user may not be able to
see previous customization
2019-05-29 10:15:10 +05:30
jibin jose
1a58c13966 fix(postgres): Make db queries postgres compatible 2019-05-20 12:31:30 +05:30
Sahil Khan
a831abefda fix(patch): reload dynamic link doctype 2019-05-14 18:56:24 +05:30
Nabin Hait
d7cd3cab21
patch: remove user perm for page and report doctype (#7383)
* fix: status options for integration request

* patch: remove user perm for page and report doctype
2019-05-01 15:53:16 +05:30
Faris Ansari
f9b3a6c242 fix: Minor changes for smooth migration to v12 2019-03-11 05:29:50 +00:00
Frappe Bot
94ea028db3 Merge branch 'master' into develop 2019-03-08 09:38:18 +00:00
Sahil Khan
964fe26801 fix(patch): ignore mandatory for creating contact through patch 2019-03-07 12:38:53 +05:30
Sagar Vora
d11dd760f8 Merge branch 'master' into develop 2019-02-26 17:06:13 +05:30
Rohit Waghchaure
65b646e59e fix: Removed duplicate page user permissions for page and report 2019-02-24 08:22:25 +05:30