Commit graph

184 commits

Author SHA1 Message Date
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Ankush Menat
970a740164
revert: #22308 (#22389)
* Revert "chore: move function to correct file"

This reverts commit ebfdfa283b.

* Revert "refactor!: merge get_site_url into get_url (#22308)"

This reverts commit 2001bc278f.
2023-09-13 14:34:52 +05:30
David Arnold
2001bc278f
refactor!: merge get_site_url into get_url (#22308)
* chore: merge get_site_url into get_url

* fix: keep alias with deprecation notice
2023-09-11 15:09:05 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
Ankush Menat
91e0d1a439
fix: Migrate color fields to color doctype (#20011) 2023-02-13 16:17:34 +05:30
Ankush Menat
b889bb5b5a fix: list view setting patch failures
- make idempotent
- ignore ordering (fails as it tries to query order which might not
  exist
2023-02-03 13:28:59 +05:30
Ankush Menat
e00023deb1 refactor: replace bad usage of db.set_value 2023-01-04 11:13:53 +05:30
Sagar Vora
036574f547 fix: patch to remove share on existing sites 2022-12-17 07:57:02 +00:00
Ankush Menat
a7377d23fc
refactor!: Drop deprecated functionality (#18815) 2022-11-11 19:54:36 +05:30
phot0n
0ece578e41 chore: remove delete_event_producer_and_consumer_keys patch 2022-08-26 18:51:18 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Sagar Vora
85a3837b14
fix: ensure 2FA patch sets parent only for 2FA keys (#17575)
* fix: ensure 2FA patch sets parent only for 2FA keys

* fix: try to rebuild defaults

* fix: set other app defaults as well

* fix: set POS profile defaults

* fix: exists params

* chore: remove unnecessary change

* fix: handle case where POS Profile doesnt exist

* chore: move erpnext code to erpnext
2022-07-21 13:04:47 +05:30
Sagar Vora
a822092211 fix: remove redundant condition 2022-07-18 22:16:25 +05:30
Sagar Vora
17b3f171ff fix: update patch to use case when...then 2022-07-11 13:18:19 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Ankush Menat
d35d7ffbe2 fix: remove bare exception catching
A bare except catches lots of things (like generator iteration end) and should never be used.
2022-06-28 18:05:00 +05:30
Ankush Menat
214be6a7e8 chore: discard stale patches, add relevant ones to patches.txt 2022-06-16 14:10:01 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Nabin Hait
21b997bd8b
fix: delete chat message attachments (#15852) 2022-02-03 13:09:12 +05:30
Suraj Shetty
6f5feb05fa fix: Add patch to remove chat related doctypes 2022-01-28 14:24:26 +05:30
Shadrak Gurupnor
c3409c818e
fix: patch for validating options field (#15565)
* fix: patch for validating options field

* fix: reorder patch execution

* refactor: reduce queries for patching

* refactor: change patch name and license

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-01-15 14:45:01 +00:00
Suraj Shetty
5d5ad78789 refactor: Rename week_starts_on to first_day_of_the_week
For consistency
2022-01-05 14:54:46 +05:30
Suraj Shetty
ca9b2a953d fix: Add patch to set week_starts_on as "Monday" 2022-01-04 13:25:19 +05:30
Shridhar Patil
92aeb972b6
fix: fixed query to run on postgres db (#15239) 2021-12-12 05:10:25 +00:00
Shridhar Patil
6acbfd5e74
fix: Make query Postgres compatible (#15240)
* fix: updated query compatibale with postgres

* fix: updated query compatible with postgres
2021-12-12 05:01:06 +00:00
Shariq Ansari
eb6a93f76d fix: ignore route conflict validation for rename_custom_client_script patch 2021-11-11 16:29:04 +05:30
Gavin D'souza
43459749e2 Merge branch 'develop' into trim-db 2021-09-06 11:35:59 +05:30
Gavin D'souza
62593c49fb refactor: Rename arg table to doctype
This change was made to be "more accurate" about how the internal magic handled
2021-09-03 20:14:40 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
saxenabhishek
7671e78487 style: minor fixes and improvements 2021-07-30 11:29:41 +05:30
saxenabhishek
45d1afe739 refactor: move rename, change_column_type, DESC to db 2021-07-30 11:00:35 +05:30
saxenabhishek
90cd4f708c refactor: qb in patch v13 increase_password_length 2021-07-30 11:00:34 +05:30
Leela vadlamudi
32a266927f
Merge pull request #13800 from leela/revert-amend-doc-feat
Revert "refactor: set amended docname to original docname"
2021-07-30 06:45:59 +05:30
Gavin D'souza
01d275f667 style: Format code for better readability
* Remove trailing whitespaces
* Format code to fit module conventions
* Add appropriate new lines between imports, classes, fn defs, etc
* Added comments, docstrings & module headers
2021-07-28 18:55:27 +05:30
leela
b719e1481d Revert "refactor: set amended docname to original docname"
This reverts commit d459847ae3.
2021-07-28 17:00:12 +05:30
Gavin D'souza
a02848849d Merge branch 'develop' of github.com:frappe/frappe into at-queries 2021-07-28 16:00:46 +05:30
Aradhya-Tripathi
84ff1d0af9 style: removed frappe.db.sql comments 2021-07-28 13:48:01 +05:30
Aradhya-Tripathi
2f3371d873 refactor: Moved raw queries to frappe orm 2021-07-23 23:14:24 +05:30
leela
d459847ae3 refactor: set amended docname to original docname
Currently, whenever a document is amended it's name is set
to name-X(X is a counter) when amended again and so on. In this PR,
we have changed all cancelled doc patterns to name-CAN-X,
so that amended docs can use the original name instead of name-X.
2021-07-21 10:51:32 +05:30
leela
f31d01a2a6 Revert "Merge pull request #13244 from prssanna/amended-doc-naming"
This reverts commit 58b95662c2, reversing
changes made to c553b7e23a.
2021-07-02 17:43:16 +05:30
Leela vadlamudi
4800ee8725
Merge branch 'develop' into amended-doc-naming 2021-07-02 10:47:47 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
prssanna
b550e54f15 fix: add column in patch 2021-05-17 17:13:51 +05:30
prssanna
0c603f0d76 test: fix cancel docs tests 2021-05-17 17:13:51 +05:30
Prssanna Desai
2cf5915eee fix: use get_meta
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
2021-05-17 17:13:51 +05:30
prssanna
ba267b6e62 fix: update patch 2021-05-17 17:13:51 +05:30
prssanna
1c4e1bc1df refactor: set amended docname to original docname 2021-05-17 17:12:28 +05:30
shariquerik
d8d133e6c3 fix: sider fix 2021-05-03 19:48:52 +05:30