No description
Find a file
Kevin Shenk 0c0fbc4248
fix: skip invalid numbers on SMS receiver_list (#22879)
This PR switches the loop in the `validate_receiver_nos` function in the SMS Settings Doctype from `break` to `continue`.

The prior functionality would throw an error if any recipients on the receiver_list were invalid, which created an issue with SMS notifications that send to a user role, since any user without a valid mobile phone number would prevent the notification sending to any users (even those with valid mobile numbers).

By switching the loop from `break` to `continue`, the function still eliminates invalid entries and enforces the existence of at least one valid phone number, but doesn't break sending based on a single absent or invalid recipient entry.

[skip ci]
2023-10-30 18:47:14 +05:30
.github chore(deps): bump actions/setup-node from 3 to 4 (#22881) 2023-10-24 12:14:47 +05:30
cypress Merge branch 'develop' into fix-attach-before-doc-save 2023-10-19 11:40:20 +05:30
esbuild fix: Remove unused resolve in code 2023-07-25 18:20:00 +05:30
frappe fix: skip invalid numbers on SMS receiver_list (#22879) 2023-10-30 18:47:14 +05:30
realtime chore: Fix codestyle to satisfy linter, and typo. (#22954) 2023-10-28 17:12:39 +05:30
.coveragerc ci: Add Coveragerc (#22530) 2023-10-16 18:24:16 +05:30
.editorconfig chore: editorconfig handle doctype.json files 2023-01-11 17:08:48 +05:30
.eslintignore fix: Miscellaneous changes (#12343) 2021-02-08 12:05:37 +05:30
.eslintrc fix: All ESLint errors 2023-07-14 15:25:48 +05:30
.flake8 chore(flake8): ignore B028 (#19612) 2023-01-17 10:55:54 +05:30
.git-blame-ignore-revs chore: ignore redis.cache commit 2023-06-08 11:48:06 +05:30
.gitignore fix: Add missing licences for vendored library 2022-07-04 08:29:56 +05:30
.mergify.yml ci: update ci config to consider v15 (#22822) 2023-10-19 15:39:05 +05:30
.pre-commit-config.yaml ci: tweak eslint rules 2023-07-14 15:09:58 +05:30
.releaserc ci: better release notes generation (#19380) 2022-12-21 12:14:35 +05:30
.semgrepignore refactor!: Prefix all custom fieldnames created from Desk (#21355) 2023-06-19 18:22:36 +05:30
attributions.md refactor: Itenticon 2022-08-11 23:53:21 +05:30
CODE_OF_CONDUCT.md Create CODE_OF_CONDUCT.md 2017-09-12 09:14:34 +05:30
codecov.yml ci: update codecov.yml flags 2023-01-10 13:19:12 +05:30
CODEOWNERS chore: simple codeowners 2023-07-25 13:06:49 +05:30
commitlint.config.js style: format JS files with prettier 2022-08-04 14:51:01 +05:30
cypress.config.js chore: Fix cypress configuration to support cy13 2023-09-22 12:02:19 +05:30
generate_bootstrap_theme.js chore: remove eslint-disable* 2023-07-14 15:41:20 +05:30
hooks.md chore!: remove dead hooks app_icon & app_color 2022-05-10 14:41:01 +05:30
LICENSE chore: Update copyright until date to 2021 2021-09-03 12:19:15 +05:30
node_utils.js fix: align to socketio port default 9000 (#22277) 2023-09-02 11:28:10 +05:30
package.json feat: show preview on popover if file is image type 2023-09-15 17:17:22 +05:30
pyproject.toml chore: bump werkzeug to 3.0.1 (#22945) 2023-10-27 16:47:26 +05:30
README.md chore: fix typo in README.md 2023-08-09 01:06:47 +09:00
SECURITY.md Update SECURITY.md 2023-01-10 16:49:44 +05:30
sider.yml chore(sider): add sider default config for flake8 + ignore tab errors (W191) (#12587) 2021-03-16 17:07:41 +05:30
socketio.js refactor: Split socketio in multiple logical files 2023-07-01 10:53:34 +05:30
yarn.lock build(deps): bump postcss from 8.4.24 to 8.4.31 (#22615) 2023-10-10 14:17:12 +05:30


a web framework with "batteries included"

it's pronounced - fra-pay

Full-stack web application framework that uses Python and MariaDB on the server side and a tightly integrated client side library. Built for ERPNext.

Login for the PWD site: (username: Administrator, password: admin)

Table of Contents

Installation

Production

Development

Contributing

  1. Code of Conduct
  2. Contribution Guidelines
  3. Security Policy
  4. Translations

Resources

  1. frappeframework.com - Official documentation of the Frappe Framework.
  2. frappe.school - Pick from the various courses by the maintainers or from the community.

License

This repository has been released under the MIT License.

By contributing to Frappe, you agree that your contributions will be licensed under its MIT License.