vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
seitime-frappe/frappe
History
Andy Zhu 209393ecbd
Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417) 
* fix: sender is not set to current user

I am not sure if I did it right:
1. import frappe
2. check if the sender is None: using frappe.session.user to fetch email address for current user

* fix: update the correct field name for S3-backup-setting

The field variable name should be updated to 'notify_email' instead of 'notification_email'.

* style: remove a trailing whitespace

* fix: Assign notify_email instead of calling frappe.db.get_value twice

* chore: remove default sender and notify_email check

* default sender already gets set in queue.py, so there's no need for a
  check inside __init__.py

* notify_email seems to be a mandatory field, so there's no need to
  check if the field has a value (assuming that it always will).

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2020-02-08 14:36:05 +05:30
..
automation fix: Invalid syntax 2020-02-03 16:03:13 +05:30
change_log fix: more url fixes 2019-07-24 16:09:56 +05:30
chat chore: fix indentation and cleanup annoying spaces 2019-12-27 13:24:59 +05:30
commands Merge pull request #9198 from gavindsouza/build-refact 2020-01-06 05:53:18 +00:00
config feat: add event streaming to automation module page 2020-01-27 16:31:05 +05:30
contacts fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
core fix: reset reset_password_key on password update using link (#9421) 2020-02-05 18:45:16 +05:30
custom Merge pull request #9428 from prssanna/customize-form-print-format 2020-02-07 16:55:52 +00:00
data Merge branch 'staging' into develop 2018-12-19 06:30:46 +00:00
data_migration Undefined name: e in data_migration_run.py 2019-11-02 13:12:45 +01:00
database fix(translations): Incorrect syntax 2020-01-29 15:35:28 +05:30
desk fix: Undo client side changes 2020-02-05 11:53:36 +05:30
email Merge pull request #9366 from prssanna/notification-fix 2020-01-30 16:36:53 +00:00
event_streaming fix: anti-pattern code 2020-01-27 14:07:13 +05:30
geo feat(translation): add Filipino language 2020-01-30 19:07:23 +05:30
integrations Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417) 2020-02-08 14:36:05 +05:30
model Merge pull request #9363 from prssanna/workflow-fix 2020-02-05 10:04:49 +00:00
modules fix: anti-pattern code 2020-01-27 12:26:12 +05:30
patches fix(patch): reload Prepared Report doctype 2020-01-15 13:18:52 +05:30
printing fix: reset default letterhead (#9380) 2020-02-03 19:57:44 +05:30
public Merge pull request #9309 from ci2014/patch-32 2020-02-07 22:42:57 +05:30
social style: Fix deepsource 2019-11-20 17:28:12 +05:30
templates fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
tests test: remove explicit commit 2020-01-22 17:56:55 +05:30
translations feat: Updated translation (#9354) 2020-02-02 16:03:41 +05:30
utils fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
website fix: regex to validate email id (#9323) 2020-01-20 19:04:37 +05:30
workflow Merge pull request #9363 from prssanna/workflow-fix 2020-02-05 10:04:49 +00:00
www fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
__init__.py Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417) 2020-02-08 14:36:05 +05:30
api.py Merge pull request #8567 from ruchamahabal/offline-erpnext 2020-01-27 11:58:15 +00:00
app.py chore: update werkzeug to 1.0.0 2020-02-07 12:16:42 +05:30
auth.py perf: Speed improvements for moduleview get (#9079) 2019-12-24 13:12:57 +05:30
boot.py perf(boot): Query all report_types at once 2019-10-23 23:00:03 +05:30
build.py refactor: updated variable name + style fixes 2020-01-04 10:53:53 +05:30
cache_manager.py fix: typo in hooks for after insert breaking cache rebuild (#9314) 2020-01-20 13:51:19 +05:30
client.py fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
defaults.py Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
deferred_insert.py fix: deferred insert json.loads() typeError (#6577) 2018-12-06 20:14:51 +05:30
exceptions.py fix: added FileNotFoundError compatability (#8342) 2019-09-05 13:17:40 +05:30
frappeclient.py fix: anti-pattern code 2020-01-27 12:26:12 +05:30
handler.py fix: conflicts 2019-11-13 11:23:30 +05:30
hooks.py Merge branch 'develop' into offline-erpnext 2020-01-24 09:23:15 +05:30
installer.py feat: Allow full database config on creating site (#8874) 2019-12-12 13:17:07 +05:30
middlewares.py chore: update werkzeug to 1.0.0 2020-02-07 12:16:42 +05:30
migrate.py reactor(scheduler): created "Scheduler Job Type" and cleaned up scheduler 2019-11-07 12:14:09 +05:30
modules.txt fix: rename Events Streaming to Event Streaming 2019-12-26 14:29:08 +05:30
oauth.py update(frappe): Update dependency Oauthlib (#6832) 2019-01-31 16:35:57 +05:30
patches.txt Merge version-12-hotfix to develop (#9095) 2019-12-23 12:24:52 +05:30
permissions.py fix: Use get_all instead of get_list 2019-09-11 15:58:36 +05:30
pythonrc.py
realtime.py frappe: refactor async to realtime (#6015) 2018-08-28 15:31:20 +05:30
recorder.py fix: frappe.conf.db_type -> frappe.db.db_type 2019-05-24 11:44:28 +05:30
sessions.py feat: onboarding wizard with configurable slides 2019-11-21 20:21:13 +05:30
share.py fix(translations): Incorrect syntax 2020-01-29 15:22:35 +05:30
test_runner.py Merge remote-tracking branch 'origin/develop' into ci/reports 2019-12-14 14:38:43 +01:00
translate.py fix(translations): Extract messages from .vue files (#8403) 2019-09-13 12:42:04 +05:30
twofactor.py fix(tests): strict redis 2019-11-07 12:14:09 +05:30