vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
seitime-frappe/frappe/utils
History
Abhishek M 378149375d
fix: Passing dev server variable to jenv globals correctly (#16843) 
Encountered the same issue during a fresh setup: https://discuss.erpnext.com/t/v13-fresh-install-develop-socket-io-using-wrong-port/74562

The problem originates from the `socketio_client.js` file.  During development, the `socket.io` client by default sends request to port 8000 but ideally it should've been 9000 (that's where it's actually running) since the latter is defined in `frappe.boot.socketio_port`. This is happening because the `jenv` variable `dev_server` is always being returned as 0.

In [this](0f7d8e7903/frappe/__init__.py (L237)) line, we are seting `frappe.local.dev_server` but in safe exec we are using `frappe._dev_server` as the source to populate the variable `dev_server` which eventually gets pushed to the `app.html` via `jinja`. (`frappe._dev_server` evaluates to `None`)

In `socketio_client`, we are using [this](0f7d8e7903/frappe/public/js/frappe/socketio_client.js (L112)) variable as a flag to decide whether or not `frappe.boot.socketio_port` should be the port that the `socket.io` client connects to.
2022-05-18 09:19:24 +00:00
..
__init__.py Merge pull request #15538 from noahjacob/phone_field_control 2022-04-28 10:27:52 +05:30
background_jobs.py Merge branch 'develop' of github.com:frappe/frappe into bg-rename_doc 2022-04-14 13:41:56 +05:30
backups.py fix: Replace password with asterisks before logging (#16743) 2022-04-26 10:30:46 +00:00
bench_helper.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
boilerplate.py chore!: remove dead hooks app_icon & app_color 2022-05-10 14:41:01 +05:30
change_log.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
commands.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
connections.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
csvutils.py refactor: Remove dead code (#16886) 2022-05-12 18:04:44 +05:30
dashboard.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
data.py chore: misleading typehint 2022-05-12 11:30:05 +05:30
dateutils.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
diff.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
doctor.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
error.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
file_lock.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
file_manager.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
fixtures.py refactor: Sync fixtures 2022-04-26 23:43:07 +02:00
formatters.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
global_search.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
goal.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
html_utils.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
identicon.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
image.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
install.py fix: only set home_page in after_install, if the key doesn't have value 2022-05-11 16:18:14 +05:30
jinja.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
jinja_globals.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
lazy_loader.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
logger.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
make_random.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
momentjs.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
nestedset.py perf: dont query for impossible child/ancestor (#16577) 2022-04-12 13:31:57 +05:30
oauth.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
password.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
password_strength.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
pdf.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
print_format.py fix(linting): no single quotes :'| 2022-04-18 17:29:03 +05:30
redis_queue.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
redis_wrapper.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
response.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
safe_exec.py fix: Passing dev server variable to jenv globals correctly (#16843) 2022-05-18 09:19:24 +00:00
scheduler.py fix: Show site name along with debugging messages 2022-05-10 13:33:53 +05:30
testutils.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
user.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
verified_command.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
weasyprint.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30
xlsxutils.py style: format all python files using black (#16453) 2022-04-12 10:59:25 +05:30