5881c5dbec
* ci(semgrep): add more rules, r/python.correctness - Added file for defining rules as per frappe data model: frappe_correctness.yml - Add rule for SQLi, with WARNING only for now - Add rule file for UX - WARNING | INFO do not fail the build now * ci(semgrep): on_cancel, on_submit correctness rule * ci(semgrep): split workflow in steps * ci(semgrep): catch line breaks in _() * chore: fix sider issue
28 lines
648 B
Python
28 lines
648 B
Python
import frappe
|
|
from frappe import _, flt
|
|
|
|
from frappe.model.document import Document
|
|
|
|
|
|
def on_submit(self):
|
|
if self.value_of_goods == 0:
|
|
frappe.throw(_('Value of goods cannot be 0'))
|
|
# ruleid: frappe-modifying-after-submit
|
|
self.status = 'Submitted'
|
|
|
|
def on_submit(self): # noqa
|
|
if flt(self.per_billed) < 100:
|
|
self.update_billing_status()
|
|
else:
|
|
# todook: frappe-modifying-after-submit
|
|
self.status = "Completed"
|
|
self.db_set("status", "Completed")
|
|
|
|
class TestDoc(Document):
|
|
pass
|
|
|
|
def validate(self):
|
|
#ruleid: frappe-modifying-child-tables-while-iterating
|
|
for item in self.child_table:
|
|
if item.value < 0:
|
|
self.remove(item)
|