seitime-frappe/frappe/data_migration
Christian Clauss fac8dbff01
Undefined name: e in data_migration_run.py
The current code raises a NameError which is never logged.

[flake8](http://flake8.pycqa.org) testing of https://github.com/frappe/frappe on Python 3.8.0

$ __flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics__
```
./frappe/data_migration/doctype/data_migration_run/data_migration_run.py:417:63: F821 undefined name 'e'
					self.update_log('pull_failed', {migration_id_value: cstr(e)})
                                                              ^
./frappe/patches/v5_0/fix_email_alert.py:12:37: F821 undefined name 'email_alert'
				notification.days_in_advance = -email_alert.days_in_advance
                                    ^
2     F821 undefined name 'e'
2
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2019-11-02 13:12:45 +01:00
..
doctype Undefined name: e in data_migration_run.py 2019-11-02 13:12:45 +01:00
__init__.py Data Migration Tool (for hub) (#4144) 2017-10-05 11:15:35 +05:30