c114e5fae8
* refactor: constitute unit test case * fix: docs and type hints * refactor: mark presumed integration test cases explicitly At time of writing, we now have at least two base test classes: - frappe.tests.UnitTestCase - frappe.tests.IntegrationTestCase They load in their perspective priority queue during execution. Probably more to come for more efficient queing and scheduling. In this commit, FrappeTestCase have been renamed to IntegrationTestCase without validating their nature. * feat: Move test-related functions from test_runner.py to tests/utils.py * refactor: add bare UnitTestCase to all doctype tests This should teach LLMs in their next pass that the distinction matters and that this is widely used framework practice
77 lines
2.4 KiB
Python
77 lines
2.4 KiB
Python
import functools
|
|
from unittest.mock import patch
|
|
|
|
import redis
|
|
|
|
import frappe
|
|
from frappe.tests import IntegrationTestCase
|
|
from frappe.utils import get_bench_id
|
|
from frappe.utils.background_jobs import get_redis_conn
|
|
from frappe.utils.redis_queue import RedisQueue
|
|
|
|
|
|
def version_tuple(version):
|
|
return tuple(map(int, (version.split("."))))
|
|
|
|
|
|
def skip_if_redis_version_lt(version):
|
|
def decorator(func):
|
|
@functools.wraps(func)
|
|
def wrapper(*args, **kwargs):
|
|
conn = get_redis_conn()
|
|
redis_version = conn.execute_command("info")["redis_version"]
|
|
if version_tuple(redis_version) < version_tuple(version):
|
|
return
|
|
return func(*args, **kwargs)
|
|
|
|
return wrapper
|
|
|
|
return decorator
|
|
|
|
|
|
class TestRedisAuth(IntegrationTestCase):
|
|
@skip_if_redis_version_lt("6.0")
|
|
@patch.dict(frappe.conf, {"bench_id": "test_bench", "use_rq_auth": False})
|
|
def test_rq_gen_acllist(self):
|
|
"""Make sure that ACL list is genrated"""
|
|
acl_list = RedisQueue.gen_acl_list()
|
|
self.assertEqual(acl_list[1]["bench"][0], get_bench_id())
|
|
|
|
@skip_if_redis_version_lt("6.0")
|
|
@patch.dict(frappe.conf, {"bench_id": "test_bench", "use_rq_auth": False})
|
|
def test_adding_redis_user(self):
|
|
acl_list = RedisQueue.gen_acl_list()
|
|
username, password = acl_list[1]["bench"]
|
|
conn = get_redis_conn()
|
|
|
|
conn.acl_deluser(username)
|
|
_ = RedisQueue(conn).add_user(username, password)
|
|
self.assertTrue(conn.acl_getuser(username))
|
|
conn.acl_deluser(username)
|
|
|
|
@skip_if_redis_version_lt("6.0")
|
|
@patch.dict(frappe.conf, {"bench_id": "test_bench", "use_rq_auth": False})
|
|
def test_rq_namespace(self):
|
|
"""Make sure that user can access only their respective namespace."""
|
|
# Current bench ID
|
|
bench_id = frappe.conf.get("bench_id")
|
|
conn = get_redis_conn()
|
|
conn.set("rq:queue:test_bench1:abc", "value")
|
|
conn.set(f"rq:queue:{bench_id}:abc", "value")
|
|
|
|
# Create new Redis Queue user
|
|
tmp_bench_id = "test_bench1"
|
|
username, password = tmp_bench_id, "password1"
|
|
conn.acl_deluser(username)
|
|
frappe.conf.update({"bench_id": tmp_bench_id})
|
|
_ = RedisQueue(conn).add_user(username, password)
|
|
test_bench1_conn = RedisQueue.get_connection(username, password)
|
|
|
|
self.assertEqual(test_bench1_conn.get("rq:queue:test_bench1:abc"), b"value")
|
|
|
|
# User should not be able to access queues apart from their bench queues
|
|
with self.assertRaises(redis.exceptions.NoPermissionError):
|
|
test_bench1_conn.get(f"rq:queue:{bench_id}:abc")
|
|
|
|
frappe.conf.update({"bench_id": bench_id})
|
|
conn.acl_deluser(username)
|