seitime-frappe/frappe/desk/listview.py
Ankush Menat 82264e7986
fix: keep a large enough limit on group-by query (#28754)
Small change on top of https://github.com/frappe/frappe/pull/28740

Reason: Site with many many users might still have huge # of rows being
returned. E.g. FC.

This just makes UX slightly bad, but there's easy workaround for it.
Users can just apply this filter -> "Owner = Self", whether users know
it or not is a different question.
2024-12-12 05:11:46 +00:00

100 lines
2.6 KiB
Python

# Copyright (c) 2022, Frappe Technologies Pvt. Ltd. and Contributors
# License: MIT. See LICENSE
import frappe
from frappe.model import is_default_field
from frappe.query_builder import Order
from frappe.query_builder.functions import Count
from frappe.query_builder.terms import SubQuery
from frappe.query_builder.utils import DocType
@frappe.whitelist()
def get_list_settings(doctype):
try:
return frappe.get_cached_doc("List View Settings", doctype)
except frappe.DoesNotExistError:
frappe.clear_messages()
@frappe.whitelist()
def set_list_settings(doctype, values):
try:
doc = frappe.get_doc("List View Settings", doctype)
except frappe.DoesNotExistError:
doc = frappe.new_doc("List View Settings")
doc.name = doctype
frappe.clear_messages()
doc.update(frappe.parse_json(values))
doc.save()
@frappe.whitelist()
def get_group_by_count(doctype: str, current_filters: str, field: str) -> list[dict]:
current_filters = frappe.parse_json(current_filters)
if field == "assigned_to":
ToDo = DocType("ToDo")
User = DocType("User")
count = Count("*").as_("count")
filtered_records = frappe.qb.get_query(
doctype,
filters=current_filters,
fields=["name"],
validate_filters=True,
)
return (
frappe.qb.from_(ToDo)
.from_(User)
.select(ToDo.allocated_to.as_("name"), count)
.where(
(ToDo.status != "Cancelled")
& (ToDo.allocated_to == User.name)
& (User.user_type == "System User")
& (ToDo.reference_name.isin(SubQuery(filtered_records)))
)
.groupby(ToDo.allocated_to)
.orderby(count, order=Order.desc)
.limit(50)
.run(as_dict=True)
)
meta = frappe.get_meta(doctype)
if not meta.has_field(field) and not is_default_field(field):
raise ValueError("Field does not belong to doctype")
data = frappe.get_list(
doctype,
filters=current_filters,
group_by=f"`tab{doctype}`.{field}",
fields=["count(*) as count", f"`{field}` as name"],
order_by="count desc",
limit=1000,
)
if field == "owner":
owner_idx = None
for idx, item in enumerate(data):
if item.name == frappe.session.user:
owner_idx = idx
break
if owner_idx:
data = [data.pop(owner_idx)] + data[0:49]
else:
data = data[0:50]
else:
data = data[0:50]
# Add in title if it's a link field and `show_title_field_in_link` is set
if (field_meta := meta.get_field(field)) and field_meta.fieldtype == "Link":
link_meta = frappe.get_meta(field_meta.options)
if link_meta.show_title_field_in_link:
title_field = link_meta.get_title_field()
for item in data:
item.title = frappe.get_value(field_meta.options, item.name, title_field)
return data