No description
Find a file
Raffael Meyer f4fa4d303f
fix: "You viewed/edited/created this" (#17365)
### Issues
In the form timeline we show events like “{user} {created/viewed/edited} this {some_time_ago}”. If user is the current user, we used “You” instead of “Jon Doe”. This works in English, but in other languages it messes up the rest of the sentence.

Because of this, people added wrong translations of “You” that made the grammar work, but also made the message less clear.

Also, the _last viewed_ message used to link to **View Log**. That can be read by system managers only and doesn't hold additional information. So it's just a source of errors for users trying to click on it.

### Fixes

- don't mix up users and salutations. Always show user's full name.
- change the _last viewed_ message to work like the other two, remove link to **View Log**

### Demo

Logged an as Administrator:

English

![Bildschirmfoto 2022-06-30 um 15 28 37](https://user-images.githubusercontent.com/14891507/176689772-dd878c90-4a2c-4a32-aa6c-d2e14a6340e1.png)

German

![Bildschirmfoto 2022-06-30 um 15 28 03](https://user-images.githubusercontent.com/14891507/176689812-ce13bb31-6c70-40f2-8699-6fb0db1d06f9.png)
2022-07-04 14:03:31 +00:00
.github ci: faster patch test (#17386) 2022-07-04 12:09:03 +05:30
cypress fix: show "doc modifed after" load message 2022-06-21 20:25:54 +05:30
esbuild chore: set esbuild output target to es2017 2022-04-01 21:30:42 +05:30
frappe fix: "You viewed/edited/created this" (#17365) 2022-07-04 14:03:31 +00:00
.editorconfig chore: extend editorconfig to vue components 2021-08-25 20:12:55 +05:30
.eslintignore fix: Miscellaneous changes (#12343) 2021-02-08 12:05:37 +05:30
.eslintrc chore: eslint - use es2020 for parsing 2022-04-18 15:06:23 +05:30
.flake8 chore: useless flake8 warnings 2022-06-15 17:27:04 +05:30
.git-blame-ignore-revs ci: force modern python with pyupgrade (#17370) 2022-07-01 12:09:27 +05:30
.gitignore chore: VS2022 uses .vs instead of .vscode. Add .vs to .gitignore. 2021-12-13 11:16:11 +11:00
.mergify.yml ci: Update mergify.yml 2022-06-16 12:07:55 +05:30
.pre-commit-config.yaml ci: force modern python with pyupgrade (#17370) 2022-07-01 12:09:27 +05:30
.releaserc chore: fix semantic release config 2022-06-02 12:06:37 +05:30
.snyk [Snyk] Fix for 1 vulnerabilities (#11523) 2020-09-17 10:00:48 +05:30
.stylelintrc fix: Miscellaneous changes (#12343) 2021-02-08 12:05:37 +05:30
attributions.md Non Pour Accent! (#5427) 2018-04-10 22:53:42 -08:00
bandit.yml fix(tests): tests and linting 2019-02-13 16:50:34 +05:30
CODE_OF_CONDUCT.md Create CODE_OF_CONDUCT.md 2017-09-12 09:14:34 +05:30
codecov.yml refactor: Clean up whitespace & add CI check 2022-02-25 20:01:29 +05:30
CODEOWNERS ci: Remove dependency on requirements.txt for builds 2022-06-15 15:25:26 +05:30
cypress.json chore: colocate ui tests 2022-01-03 16:19:11 +05:30
generate_bootstrap_theme.js fix: Common sass_options 2021-04-27 11:24:19 +05:30
hooks.md chore!: remove dead hooks app_icon & app_color 2022-05-10 14:41:01 +05:30
LICENSE chore: Update copyright until date to 2021 2021-09-03 12:19:15 +05:30
node_utils.js fix: set correct default redis async broker in node_utils 2021-05-21 16:09:43 +05:30
package.json chore!: remove deprecated quaggajs based barcode scanner (#17248) 2022-06-20 21:04:30 +05:30
pyproject.toml build!: Bump minimum Python version to 3.10 2022-06-30 13:11:26 +05:30
README.md style(README): Fixed inconsistent whitespaces 2022-04-28 14:52:42 +05:30
SECURITY.md chore: updated Security policy and issue template 2019-10-12 12:06:36 +05:30
setup.py fix: Add temporary backwards compatible setup.py 2022-06-14 18:21:48 +05:30
sider.yml chore(sider): add sider default config for flake8 + ignore tab errors (W191) (#12587) 2021-03-16 17:07:41 +05:30
socketio.js fix: publish realtime to work with localhost (backport #14174) (#14196) 2021-09-14 12:09:01 +05:30
yarn.lock build(deps): bump shell-quote from 1.7.2 to 1.7.3 2022-06-22 10:45:05 +00:00


a web framework with "batteries included"

it's pronounced - fra-pay

Full-stack web application framework that uses Python and MariaDB on the server side and a tightly integrated client side library. Built for ERPNext

Login for the PWD site: (username: Administrator, password: admin)

Table of Contents

Installation

Contributing

  1. Code of Conduct
  2. Contribution Guidelines
  3. Security Policy
  4. Translations

Resources

  1. frappeframework.com - Official documentation of the Frappe Framework.
  2. frappe.school - Pick from the various courses by the maintainers or from the community.

License

This repository has been released under the MIT License.