seitime-frappe/frappe
Chinmay D. Pai fb511b1dfd
fix(email): check if communication hasattr for attachment
fixes issue where previous communication has no attribute _attachments
before it fails, causing the following error:

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/background_jobs.py", line 99, in execute_job
    method(**kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 724, in pull_from_email_account
    email_account.receive()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/email/doctype/email_account/email_account.py", line 295, in receive
    attachments = [d.file_name for d in communication._attachments]
AttributeError: 'Communication' object has no attribute '_attachments'

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-01-05 00:35:06 +05:30
..
automation fix(Auto Repeat): derive next date from start date and offset (#9177) 2019-12-31 18:51:09 +05:30
change_log fix: more url fixes 2019-07-24 16:09:56 +05:30
chat chore: fix indentation and cleanup annoying spaces 2019-12-27 13:24:59 +05:30
commands feat: Disable testing for all sites by default 2020-01-03 22:08:06 +05:30
config fix: Add Notification Settings 2019-11-21 17:01:33 +05:30
contacts fix: Remove changes in notifications 2019-12-06 09:26:32 +05:30
core Merge pull request #9039 from Thunderbottom/email_ssl 2020-01-01 08:38:48 +00:00
custom Merge branch 'develop' into qe_cf 2019-12-31 20:26:58 +05:30
data Merge branch 'staging' into develop 2018-12-19 06:30:46 +00:00
data_migration Undefined name: e in data_migration_run.py 2019-11-02 13:12:45 +01:00
database fix: allow setting custom database schema in site_config (#9182) 2020-01-02 22:20:04 +05:30
desk feat: Optionally remove seconds from datetime (#8531) 2019-12-25 14:54:28 +05:30
email fix(email): check if communication hasattr for attachment 2020-01-05 00:35:06 +05:30
geo feat: Optionally remove seconds from datetime (#8531) 2019-12-25 14:54:28 +05:30
integrations fix: serialize datetime objects in child table documents 2019-12-31 13:28:41 +05:30
model Merge branch 'develop' into dev-webhook-tables 2020-01-01 12:02:53 +05:30
modules Merge pull request #8480 from Mangesh-Khairnar/fix-boilerplate-creation 2019-09-24 17:11:48 +00:00
patches fix: TypeError in home_settings patch 2019-12-20 13:10:34 +05:30
printing Merge branch 'develop' into remove_onboarding_images 2019-12-18 15:42:38 +05:30
public Merge pull request #9022 from Thunderbottom/chat-fix 2020-01-01 11:10:41 +00:00
social style: Fix deepsource 2019-11-20 17:28:12 +05:30
templates fix: Use _ for translation since frappe._ is not supported 2020-01-01 09:29:12 +05:30
tests fix: whitelist function 2019-12-26 17:56:19 +05:30
translations feat: Updated translation (#8613) 2019-10-20 12:11:18 +05:30
utils fix: Make background jobs logging quieter if quite flag is pass… (#9200) 2020-01-04 19:12:59 +05:30
website feat: Custom CSS support in Web Form 2019-12-24 14:16:26 +05:30
workflow fix: Rename Reference DocType -> Reference Document Type 2019-09-05 15:47:40 +05:30
www refactor: enable translations 2019-11-19 15:39:28 +05:30
__init__.py fix: as_table msgprint (#9174) 2020-01-04 21:05:02 +05:30
api.py fix: REST API utf-8 decoding on creates/updates (#8875) 2019-12-03 06:44:11 +00:00
app.py fix: restore debugging code 2019-09-20 11:20:53 +05:30
auth.py perf: Speed improvements for moduleview get (#9079) 2019-12-24 13:12:57 +05:30
boot.py perf(boot): Query all report_types at once 2019-10-23 23:00:03 +05:30
build.py fix: python 2 compatibility for symlink creation 2020-01-02 10:10:55 +05:30
cache_manager.py perf: Speed improvements for moduleview get (#9079) 2019-12-24 13:12:57 +05:30
client.py fix(UX): Hide Amend button if the document has been already ame… (#8306) 2019-09-02 16:18:56 +05:30
defaults.py Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
deferred_insert.py fix: deferred insert json.loads() typeError (#6577) 2018-12-06 20:14:51 +05:30
exceptions.py fix: added FileNotFoundError compatability (#8342) 2019-09-05 13:17:40 +05:30
frappeclient.py chore: remove print from frappeclient 2019-10-09 16:04:04 +05:30
handler.py feat(server scripts): add server scripts! 2019-10-11 14:16:49 +05:30
hooks.py perf: Speed improvements for moduleview get (#9079) 2019-12-24 13:12:57 +05:30
installer.py feat: Allow full database config on creating site (#8874) 2019-12-12 13:17:07 +05:30
middlewares.py refactor(recorder): Remove RecorderMiddleware 2019-02-19 21:58:55 +05:30
migrate.py reactor(scheduler): created "Scheduler Job Type" and cleaned up scheduler 2019-11-07 12:14:09 +05:30
modules.txt feat: Init energy points 2019-03-19 14:08:35 +05:30
oauth.py update(frappe): Update dependency Oauthlib (#6832) 2019-01-31 16:35:57 +05:30
patches.txt Merge version-12-hotfix to develop (#9095) 2019-12-23 12:24:52 +05:30
permissions.py fix: Use get_all instead of get_list 2019-09-11 15:58:36 +05:30
pythonrc.py
realtime.py frappe: refactor async to realtime (#6015) 2018-08-28 15:31:20 +05:30
recorder.py fix: frappe.conf.db_type -> frappe.db.db_type 2019-05-24 11:44:28 +05:30
sessions.py feat: onboarding wizard with configurable slides 2019-11-21 20:21:13 +05:30
share.py fix: formatting 2019-11-04 23:39:30 +05:30
test_runner.py Merge branch 'develop' into refactor-scheduler 2019-12-02 13:16:45 +05:30
translate.py fix(translations): Extract messages from .vue files (#8403) 2019-09-13 12:42:04 +05:30
twofactor.py fix(tests): strict redis 2019-11-07 12:14:09 +05:30