fix: linting issues

This commit is contained in:
Saqib Ansari 2025-11-06 15:23:45 +05:30
parent 5625f158e3
commit 04d1c9dc04
3 changed files with 13 additions and 11 deletions

View file

@ -38,5 +38,5 @@ frappe.ui.form.on("Permission Inspector", {
"options",
`${standard_options}\n${custom_options}`
);
}
},
});

View file

@ -33,11 +33,15 @@ class IntegrationTestPermissionType(IntegrationTestCase):
self._verify_user_lacks_permission(doc_type, ptype_name, user.name)
update_permission_property(doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=1)
update_permission_property(
doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=1
)
self._verify_user_has_permission(doc_type, ptype_name, user.name)
update_permission_property(doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=0)
update_permission_property(
doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=0
)
finally:
frappe.delete_doc("User", user.name, force=True)
@ -92,12 +96,8 @@ class IntegrationTestPermissionType(IntegrationTestCase):
def _verify_user_lacks_permission(self, doc_type, ptype_name, user_name):
"""Verify that user does not have the specified permission type."""
self.assertFalse(
frappe.has_permission(doc_type, ptype=ptype_name, user=user_name)
)
self.assertFalse(frappe.has_permission(doc_type, ptype=ptype_name, user=user_name))
def _verify_user_has_permission(self, doc_type, ptype_name, user_name):
"""Verify that user has the specified permission type."""
self.assertTrue(
frappe.has_permission(doc_type, ptype=ptype_name, user=user_name)
)
self.assertTrue(frappe.has_permission(doc_type, ptype=ptype_name, user=user_name))

View file

@ -742,13 +742,15 @@ def get_doc_name(doc):
return None
return doc if isinstance(doc, str) else str(doc.name)
def get_rights(doctype = None):
def get_rights(doctype=None):
if not doctype:
return std_rights
custom_rights = get_doctype_ptype_map().get(doctype, [])
return list(std_rights) + custom_rights
def allow_everything(doctype = None):
def allow_everything(doctype=None):
"""Return a dict with access to everything, eg. {"read": 1, "write": 1, ...}."""
return {ptype: 1 for ptype in get_rights(doctype)}