vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #10911 from prssanna/view-header-fix

Browse source 
fix: only render header if columns exist
This commit is contained in:
mergify[bot] 2020-07-08 04:08:42 +00:00 • committed by GitHub
commit 211a45ae4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/public/js/frappe/list/list_view.js
View file

@ -528,6 +528,10 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
}
get_header_html() {
if (!this.columns) {
return;
}
const subject_field = this.columns[0].df;
let subject_html = `
<input class="level-item list-check-all hidden-xs" type="checkbox" title="${__("Select All")}">
@ -1146,7 +1150,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
});
this.toggle_result_area();
this.render_list();
if (this.$checks.length) {
if (this.$checks && this.$checks.length) {
this.set_rows_as_checked();
}
});

4
frappe/public/js/frappe/views/kanban/kanban_view.js
View file

@ -73,6 +73,10 @@ frappe.views.KanbanView = class KanbanView extends frappe.views.ListView {
});
}
render_list() {
}
on_filter_change() {
if (JSON.stringify(this.board.filters_array) !== JSON.stringify(this.filter_area.get())) {
this.page.set_indicator(__('Not Saved'), 'orange');