vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(DX): Log all exceptions in developer mode (#29195)

Browse source 
ALL exceptions - even validation errors. This is excessive logging but
in development mode it should be fine and even helpful in debugging few
issues.
This commit is contained in:
Ankush Menat 2025-01-16 15:50:56 +05:30 • committed by GitHub
parent 9c2bd23606
commit 430c0c7c7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/app.py
View file

@ -26,7 +26,7 @@ from frappe.auth import SAFE_HTTP_METHODS, UNSAFE_HTTP_METHODS, HTTPRequest, val
from frappe.middlewares import StaticDataMiddleware
from frappe.utils import CallbackManager, cint, get_site_name
from frappe.utils.data import escape_html
from frappe.utils.error import log_error_snapshot
from frappe.utils.error import log_error, log_error_snapshot
from frappe.website.page_renderers.error_page import ErrorPage
from frappe.website.serve import get_response
@ -390,7 +390,7 @@ def handle_exception(e):
if hasattr(frappe.local, "login_manager"):
frappe.local.login_manager.clear_cookies()
if http_status_code >= 500:
if http_status_code >= 500 or frappe.conf.developer_mode:
log_error_snapshot(e)
if frappe.conf.get("developer_mode") and not respond_as_json: