vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Remove logic short circuit / dont reject fields easily

Browse source
This commit is contained in:
Gavin D'souza 2023-01-16 14:51:31 +05:30
parent 85d6949d04
commit 47bcc527f3
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/model/db_query.py
View file

@ -564,11 +564,6 @@ class DatabaseQuery:
permitted_fields = get_permitted_fields(doctype=self.doctype)
for i, field in enumerate(self.fields):
# field: like 'name', 'published'
if is_plain_field(field) and field not in permitted_fields:
self.fields.remove(field)
continue
if "distinct" in field.lower():
# field: 'count(distinct `tabPhoto`.name) as total_count'
# column: 'tabPhoto.name'
@ -582,9 +577,10 @@ class DatabaseQuery:
if column == "*" and not in_function("*", field):
self.fields[i : i + 1] = permitted_fields
continue
# handle pseudo columns
elif not column:
elif not column or column.isnumeric():
continue
# labels / pseudo columns or frappe internals