fix: commit after successfull deletion of all tasks

This commit is contained in:
Shariq Ansari 2023-06-15 12:48:55 +05:30
parent c831422703
commit 4ec2d5f00d

View file

@ -489,8 +489,6 @@ def delete_bulk(doctype, items):
dict(progress=[i + 1, len(items)], title=_("Deleting {0}").format(doctype), description=d),
user=frappe.session.user,
)
# Commit after successful deletion
frappe.db.commit()
except Exception:
# rollback if any record failed to delete
# if not rollbacked, queries get committed on after_request method in app.py
@ -499,6 +497,9 @@ def delete_bulk(doctype, items):
if undeleted_items and len(items) != len(undeleted_items):
frappe.clear_messages()
delete_bulk(doctype, undeleted_items)
else:
# Commit after successful deletion
frappe.db.commit()
@frappe.whitelist()