vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

perf: removed redundant db calls

Browse source 
Co-authored-by: gavin <gavin.dsouza@switchup.de>
This commit is contained in:
Sumit Bhanushali 2024-06-29 00:00:59 +05:30 • committed by GitHub
parent 094a0de0d0
commit 5a1cac6bc3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/core/doctype/version/version.py
View file

@ -155,10 +155,8 @@ def get_diff(old, new, for_child=False, compare_cancelled=False):
link_meta = frappe.get_meta(field_meta.options)
# Show title field value if field is Link and show_title_field_in_link is True
if link_meta.show_title_field_in_link:
title_field = link_meta.get_title_field()
old_title_val = frappe.get_value(field_meta.options, old_value, title_field)
new_title_val = frappe.get_value(field_meta.options, new_value, title_field)
if link_meta.show_title_field_in_link and ((title_field := link_meta.get_title_field()) != "name"):
old_title_val, new_title_val = frappe.db.get_values(field_meta.options, {"name": ("in", (old_value, new_value))}, title_field, pluck=True)
out.changed.append((df.fieldname, old_title_val, new_title_val))
continue
out.changed.append((df.fieldname, old_value, new_value))