vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: return early is parent doctype is single

Browse source
This commit is contained in:
Sagar Vora 2025-12-22 12:14:17 +05:30
parent 2882ed4e69
commit 7ce888d5f1
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
frappe/database/query.py
View file

@ -1406,17 +1406,22 @@ class Engine:
For child tables (when parent_doctype is specified):
- permissions are checked against the parent doctype
- a join to the parent table is added
- conditions reference the parent table's fields
- for non-single parent doctypes: a join to the parent table is added,
conditions reference parent fields
- for single parent doctypes: all permissions are already checked by has_permission,
we exit early without adding any conditions
"""
if not self.apply_permissions:
return
meta = frappe.get_meta(self.permission_doctype)
if self.permission_doctype != self.doctype:
parent_meta = frappe.get_meta(self.permission_doctype)
if parent_meta.issingle:
# Child table of single doctype
# permissions are already checked by has_permission
return
# For child tables, join to parent table so permission conditions can reference it (skip for Single doctypes)
if self.permission_doctype != self.doctype and not meta.issingle:
self.query = self.query.inner_join(self.permission_table).on(
self.table.parent == self.permission_table.name
)