vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

perf: "load more" and "increase page length" (#25081)

Browse source 
* refactor: saparate click handlers for "load more" and "change page length"

* perf: "load more" or "increase page length"

Only request the required additional data, not all data.
This commit is contained in:
Raffael Meyer 2024-02-29 17:19:32 +01:00 • committed by GitHub
parent 0fff2755d6
commit 81785ae52b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
frappe/public/js/frappe/list/base_list.js
View file

@ -45,6 +45,7 @@ frappe.views.BaseList = class BaseList {
this.start = 0;
this.page_length = frappe.is_large_screen() ? 100 : 20;
this.selected_page_count = this.page_length;
this.data = [];
this.method = "frappe.desk.reportview.get";
@ -395,20 +396,32 @@ frappe.views.BaseList = class BaseList {
this.$paging_area.on("click", ".btn-paging", (e) => {
const $this = $(e.currentTarget);
// set active button
// Set the active button
// This is always necessary because the current page length might
// have resulted from a previous "load more".
this.$paging_area.find(".btn-paging").removeClass("btn-info");
$this.addClass("btn-info");
this.start = 0;
this.page_length = this.selected_page_count = $this.data().value;
const old_page_length = this.page_length;
const new_page_length = $this.data().value;
this.refresh();
this.selected_page_count = new_page_length;
if (this.page_length > new_page_length) {
this.start = 0;
this.page_length = new_page_length;
} else {
this.start = this.page_length;
this.page_length = new_page_length - this.page_length;
}
if (old_page_length !== new_page_length) {
this.refresh();
}
});
this.$paging_area.on("click", ".btn-more", (e) => {
this.start += this.page_length;
this.page_length = this.selected_page_count || 20;
this.start = this.data.length;
this.page_length = this.selected_page_count;
this.refresh();
});
}