vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: ensure that the role exists

Browse source 
Some setups can have broken links here, resulting in a KeyError

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-10-08 16:52:57 +05:30
parent 5324431fc0
commit 84bee76aba
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/patches/v16_0/move_role_desk_settings_to_user.py
View file

@ -11,10 +11,10 @@ def execute():
for user in frappe.get_list("User"):
user_desk_settings = {}
for role_name in frappe.get_roles(username=user.name):
role = roles[role_name]
for key in desk_properties:
if role.get(key) is None:
role[key] = 1
user_desk_settings[key] = user_desk_settings.get(key) or role.get(key)
if role := roles.get(role_name):
for key in desk_properties:
if role.get(key) is None:
role[key] = 1
user_desk_settings[key] = user_desk_settings.get(key) or role.get(key)
frappe.db.set_value("User", user.name, user_desk_settings)