fix: misc client side errors (#17018)

* fix: group by button color consistency with filter

* fix: return promise from HTML.set_value

* fix: only call set_input if control supports input
This commit is contained in:
Ankush Menat 2022-05-31 14:49:12 +05:30 committed by GitHub
parent 8212aefdf3
commit 890f5dd597
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions

View file

@ -28,5 +28,6 @@ frappe.ui.form.ControlHTML = class ControlHTML extends frappe.ui.form.Control {
this.df.options = html;
this.html(html);
}
return Promise.resolve();
}
};

View file

@ -132,7 +132,7 @@ frappe.ui.FieldGroup = class FieldGroup extends frappe.ui.form.Layout {
var f = this.fields_dict[key];
if (f) {
f.set_value(val).then(() => {
f.set_input(val);
f.set_input?.(val);
this.refresh_dependency();
resolve();
});

View file

@ -104,12 +104,12 @@
}
.group-by-button.btn-primary-light {
color: var(--blue-500);
color: var(--text-on-blue);
}
.group-by-icon.active {
use {
stroke: var(--blue-500);
stroke: var(--text-on-blue);
}
}