fix: remove ignore_in_getter; cleaner implementation

This commit is contained in:
Sagar Vora 2022-02-15 13:02:20 +05:30
parent 882c68671d
commit 8a264d05ca

View file

@ -73,8 +73,7 @@ def get_controller(doctype):
return site_controllers[doctype]
class BaseDocument(object):
ignore_in_getter = ("doctype", "_meta", "meta", "_table_fields", "_valid_columns")
ignore_in_setter = ("doctype",)
ignore_in_setter = ("doctype", "_meta", "meta", "_table_fields", "_valid_columns")
def __init__(self, d):
if d.get("doctype"):
@ -148,10 +147,11 @@ class BaseDocument(object):
else:
value = self.__dict__.get(key, default)
if value is None and key not in self.ignore_in_getter \
and key in (d.fieldname for d in self.meta.get_table_fields()):
self.set(key, [])
value = self.__dict__.get(key)
if value is None and key in (
d.fieldname for d in self.meta.get_table_fields()
):
value = []
self.set(key, value)
return value
else: