vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: None is not NoneType

Browse source 
* also, rename test ;)
This commit is contained in:
Gavin D'souza 2022-02-18 20:17:39 +05:30
parent ec1817de66
commit 8aedf6410a
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/model/rename_doc.py
View file

@ -30,7 +30,7 @@ def update_document_title(
"""
# TODO: omit this after runtime type checking (ref: https://github.com/frappe/frappe/pull/14927)
for obj in [docname, new_name, new_title, old_title]:
if not isinstance(obj, (str, None)):
if not isinstance(obj, (str, type(None))):
frappe.throw(f"{obj} must be of type str or None")
frappe.has_permission(doctype, ptype="write", throw=True)

2
frappe/tests/test_rename_doc.py
View file

@ -185,7 +185,7 @@ class TestRenameDoc(unittest.TestCase):
new_name, frappe.rename_doc("Renamed Doc", old_name, new_name, force=True)
)
def test_update_title_api(self):
def test_update_document_title_api(self):
from frappe.model.rename_doc import update_document_title
allow_rename_prop = frappe.db.get_value("DocType", self.test_doctype, "allow_rename")
frappe.clear_cache()