vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Check for list_renderer before accessing settings (#5469)

Browse source 
* Check for list_renderer before accessing settings

In the master version of frappe, in the first attempt of calling the file manager (when onload is called) the report doesn't build, because in the report view, there is no such attribute list_renderer available.

In that change we check if the list renderer is not undefined and only setup the menu, drag and drop and copy function, when the list_renderer object is available.

This problem might not occur in the developer versions (datatables), but many people still work with the master version and need a working file manager report.

* Update file_list.js
This commit is contained in:
ci2014 2018-05-04 09:45:30 +02:00 • committed by Faris Ansari
parent 880d2e5101
commit 8b2e4a5f4c
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frappe/core/doctype/file/file_list.js
View file

@ -38,12 +38,15 @@ frappe.listview_settings['File'] = {
doclist.breadcrumb = $('<ol class="breadcrumb for-file-list"></ol>')
.insertBefore(doclist.filter_area);
doclist.list_renderer.settings.setup_menu(doclist);
doclist.list_renderer.settings.setup_dragdrop(doclist);
if (doclist.list_renderer) {
doclist.list_renderer.settings.setup_menu(doclist);
doclist.list_renderer.settings.setup_dragdrop(doclist);
doclist.$page.on("click", ".list-row-checkbox", function(event) {
doclist.list_renderer.settings.add_menu_item_copy(doclist);
});
doclist.$page.on("click", ".list-row-checkbox", function(event) {
doclist.list_renderer.settings.add_menu_item_copy(doclist);
});
}
},
list_view_doc:function(doclist){
$(doclist.wrapper).on("click", 'button[list_view_doc="'+doclist.doctype+'"]', function() {