vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: don't catch S3 upload error prematurely

Browse source
This commit is contained in:
barredterra 2024-09-23 14:59:24 +02:00
parent a04aba0408
commit 8d52eeafe0
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
View file

@ -187,10 +187,5 @@ def backup_to_s3():
def upload_file_to_s3(filename, folder, conn, bucket):
destpath = os.path.join(folder, os.path.basename(filename))
try:
print("Uploading file:", filename)
conn.upload_file(filename, bucket, destpath) # Requires PutObject permission
except Exception:
frappe.log_error()
notify()
print("Uploading file:", filename)
conn.upload_file(filename, bucket, destpath) # Requires PutObject permission