vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor(query_report): simplify logic

Browse source 
Reduce one level of nesting

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-09-25 17:57:13 +05:30 • committed by jabir-elat
parent b17238f997
commit 90bd55690a
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
frappe/desk/query_report.py
View file

@ -791,11 +791,10 @@ def validate_filters_permissions(report_name, filters=None, user=None):
filters = json.loads(filters)
report = frappe.get_doc("Report", report_name)
for fieldname, value in filters.items():
for field in report.filters:
if field.fieldname == fieldname and field.fieldtype == "Link":
linked_doctype = field.options
if not has_permission(doctype=linked_doctype, doc=value, user=user):
frappe.throw(
_("You do not have permission to access {0}: {1}.").format(linked_doctype, value)
)
for field in report.filters:
if field.fieldname in filters and field.fieldtype == "Link":
linked_doctype = field.options
if not has_permission(doctype=linked_doctype, doc=filters[field], user=user):
frappe.throw(
_("You do not have permission to access {0}: {1}.").format(linked_doctype, filters[field])
)