vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(report_utils): ensure that delimiter and separator can't be empty

Browse source 
This results in them setting as `undefined`, which ends up as a string
in python, and the delimiter ends up as `'u'`, and the separator as
`'undefined'`.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-04-25 17:26:12 +05:30
parent e455b7b452
commit af611d4bcb
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/public/js/frappe/views/reports/report_utils.js
View file

@ -264,8 +264,18 @@ frappe.report_utils = {
dialog.fields_dict["file_format"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_quoting"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_delimiter"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_decimal_sep"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_delimiter"].df.onchange = () => {
if (!dialog.get_value("csv_delimiter")) {
dialog.set_value("csv_delimiter", ",");
}
update_csv_preview(dialog);
};
dialog.fields_dict["csv_decimal_sep"].df.onchange = () => {
if (!dialog.get_value("csv_decimal_sep")) {
dialog.set_value("csv_decimal_sep", ".");
}
update_csv_preview(dialog);
};
return dialog;
},