vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor(minor): Use set comprehension instead of difference

Browse source
This commit is contained in:
Gavin D'souza 2021-06-01 01:32:19 +05:30
parent cd6f353175
commit b0bb0cf2c4
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/custom/doctype/customize_form/customize_form.py
View file

@ -355,8 +355,7 @@ class CustomizeForm(Document):
def delete_custom_fields(self):
meta = frappe.get_meta(self.doc_type)
fields_to_remove = (set(df.fieldname for df in meta.get("fields"))
- set(df.fieldname for df in self.get("fields")))
fields_to_remove = {df.fieldname for df in meta.get("fields") if df not in self.get("fields")}
for fieldname in fields_to_remove:
df = meta.get("fields", {"fieldname": fieldname})[0]

2
frappe/desk/doctype/global_search_settings/global_search_settings.py
View file

@ -21,7 +21,7 @@ class GlobalSearchSettings(Document):
dts.append(dt.document_type)
if core_dts:
core_dts = (", ".join(frappe.bold(dt) for dt in core_dts))
core_dts = ", ".join(frappe.bold(dt) for dt in core_dts)
frappe.throw(_("Core Modules {0} cannot be searched in Global Search.").format(core_dts))
if repeated_dts: