vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: hide Submit button on non-submittable doctypes (#36825)

Browse source 
can_submit() only checked docstatus, permissions, and workflow
but never verified the doctype is actually submittable. Since all
documents start at docstatus 0, this caused a Submit button to
appear on any non-submittable doctype where the user has submit
permission (e.g. System Manager).
This commit is contained in:
Luis Mendoza 2026-02-07 03:15:17 -03:00 • committed by GitHub
parent 25df73931b
commit b408bc92c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
frappe/public/js/frappe/form/toolbar.js
View file

@ -670,6 +670,7 @@ frappe.ui.form.Toolbar = class Toolbar {
}
can_submit() {
return (
frappe.model.is_submittable(this.frm.doc.doctype) &&
this.get_docstatus() === 0 &&
!this.frm.doc.__islocal &&
!this.frm.doc.__unsaved &&