vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix(list-view): Escape quotes in data-name (#7600)

Browse source 
Fixes misbehaviour in bulk actions when selected documents have names
with quotes.
This commit is contained in:
Aditya Hase 2019-05-30 10:52:50 +05:30 • committed by Faris Ansari
parent 37283e4e84
commit b94bbb34a9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/public/js/frappe/list/list_view.js
View file

@ -698,7 +698,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
.includes(user) ? '' : 'bold';
let subject_html = `
<input class="level-item list-row-checkbox hidden-xs" type="checkbox" data-name="${doc.name}">
<input class="level-item list-row-checkbox hidden-xs" type="checkbox" data-name="${escape(doc.name)}">
<span class="level-item" style="margin-bottom: 1px;">
<i class="octicon octicon-heart like-action ${heart_class}"
data-name="${doc.name}" data-doctype="${this.doctype}"
@ -968,7 +968,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
get_checked_items(only_docnames) {
const docnames = Array.from(this.$checks || [])
.map(check => cstr($(check).data().name));
.map(check => cstr(unescape($(check).data().name)));
if (only_docnames) return docnames;