vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor(printview): first check for doc permissions, then for website

Browse source 
This broke for some cases because people had doc permissions, but `has_website_permission()` returns False

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-01-24 16:51:16 +05:30
parent 1e8a1f64c5
commit bbfb26aaab
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/www/printview.py
View file

@ -375,13 +375,13 @@ def get_rendered_raw_commands(doc: str, name: str | None = None, print_format: s
def validate_print_permission(doc: "Document") -> None:
if frappe.has_website_permission(doc):
return
for ptype in ("read", "print"):
if frappe.has_permission(doc.doctype, ptype, doc):
return
if frappe.has_website_permission(doc):
return
if (key := frappe.form_dict.key) and isinstance(key, str):
validate_key(key, doc)
return