vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: deduplicate role profiles

Browse source
This commit is contained in:
Ankush Menat 2024-02-10 11:44:19 +05:30
parent f609025472
commit bfa1aebcc6
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frappe/core/doctype/user/user.py
View file

@ -163,6 +163,7 @@ class User(Document):
self.set_full_name()
self.check_enable_disable()
self.ensure_unique_roles()
self.ensure_unique_role_profiles()
self.remove_all_roles_for_guest()
self.validate_username()
self.remove_disabled_roles()
@ -646,12 +647,18 @@ class User(Document):
self.get("roles").remove(role)
def ensure_unique_roles(self):
exists = []
for d in self.get("roles"):
exists = set()
for d in list(self.roles):
if (not d.role) or (d.role in exists):
self.get("roles").remove(d)
else:
exists.append(d.role)
self.roles.remove(d)
exists.add(d.role)
def ensure_unique_role_profiles(self):
seen = set()
for rp in list(self.role_profiles):
if rp.role_profile in seen:
self.role_profiles.remove(rp)
seen.add(rp.role_profile)
def validate_username(self):
if not self.username and self.is_new() and self.first_name:

2
frappe/patches/v15_0/migrate_role_profile_to_table_multi_select.py
View file

@ -8,7 +8,7 @@ def execute():
)
user_profiles = get_records_to_insert(users)
bulk_insert("User Role Profile", user_profiles, ignore_duplicates=True)
frappe.db.set_value("User", {}, "role_profile_name", None)
frappe.db.set_value("User", {}, "role_profile_name", None, update_modified=None)
def get_records_to_insert(users):