vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: actually debounce list view updates (#21738)

Browse source 
Immediately debouncing and executing creates a new function everytime and doesn't actually "debounce" it just "delays". 🗿

[skip ci]
This commit is contained in:
Ankush Menat 2023-07-19 20:42:43 +05:30 • committed by GitHub
parent 453892cdef
commit c2a5adadbe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/public/js/frappe/list/list_view.js
View file

@ -24,6 +24,10 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
constructor(opts) { constructor(opts) {
super(opts); super(opts);
this.show(); this.show();
this.debounced_refresh = frappe.utils.debounce(
this.process_document_refreshes.bind(this),
2000
);
} }
has_permissions() { has_permissions() {
@ -1377,7 +1381,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
} }
this.pending_document_refreshes.push(data); this.pending_document_refreshes.push(data);
frappe.utils.debounce(this.process_document_refreshes.bind(this), 1000)(); this.debounced_refresh();
}); });
this.realtime_events_setup = true; this.realtime_events_setup = true;
} }