vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: only update primary action if it is new action is provided

Browse source 
Currently, the primary action is updated even if the new action is None.
This breaks some old code that relies on the primary action being None
when no action is provided. (used to update primary action label)

I changed the code to only update the primary action
if the new action function is provided
This commit is contained in:
Maharshi Patel 2023-12-05 23:31:58 +05:30
parent b23ee471c3
commit cb3205e569
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/public/js/frappe/ui/dialog.js
View file

@ -180,11 +180,9 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup {
this.footer.removeClass("hide");
this.has_primary_action = true;
var me = this;
return this.get_primary_btn()
.removeClass("hide")
.html(label)
.off("click")
.on("click", function () {
const primary_btn = this.get_primary_btn().removeClass("hide").html(label);
if (typeof click == "function") {
primary_btn.off("click").on("click", function () {
me.primary_action_fulfilled = true;
// get values and send it
// as first parameter to click callback
@ -193,6 +191,8 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup {
if (!values) return;
click && click.apply(me, [values]);
});
}
return primary_btn;
}
set_secondary_action(click) {