vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor(minor): Use pluck & better var naming

Browse source
This commit is contained in:
Gavin D'souza 2021-10-22 14:17:52 +05:30
parent 0410a88aea
commit cb66e6508d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/permissions.py
View file

@ -353,10 +353,10 @@ def get_roles(user=None, with_standard=True):
return frappe.get_all("Role", pluck="name") # return all available roles
else:
table = DocType("Has Role")
result = frappe.qb.from_(table).where(
roles = frappe.qb.from_(table).where(
(table.parent == user) & (table.role.notin(["All", "Guest"]))
).select(table.role).run()
return [r[0] for r in result] + ['All', 'Guest']
).select(table.role).run(pluck=True)
return roles + ['All', 'Guest']
roles = frappe.cache().hget("roles", user, get)