vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(print_utils): simplify checks

Browse source 
Make it more readable, and prevent error

Sentry FRAPPE-4SQ

```
TypeError: Cannot read properties of undefined (reading 'default_letter_head')
  at frappe.ui.get_print_settings(../../../../../apps/frappe/frappe/public/js/frappe/form/print_utils.js:6:65)
  at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1640:29)
  at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-08-22 15:25:42 +05:30
parent 7547937521
commit cfc8d7a010
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/public/js/frappe/form/print_utils.js
View file

@ -1,10 +1,12 @@
frappe.ui.get_print_settings = function (pdf, callback, letter_head, pick_columns) {
var print_settings = locals[":Print Settings"]["Print Settings"];
var default_letter_head =
locals[":Company"] && frappe.defaults.get_default("company")
? locals[":Company"][frappe.defaults.get_default("company")]["default_letter_head"]
: "";
var company = frappe.defaults.get_default("company");
var default_letter_head = "";
if (locals[":Company"] && locals[":Company"][company]) {
default_letter_head = locals[":Company"][company]["default_letter_head"] || "";
}
var columns = [
{