vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #27723 from s-aga-r/fix-system-manager-emails

Browse source 
fix: prevent sending emails to System Manager when email notifications are disabled
This commit is contained in:
Akhil Narang 2024-09-13 18:27:53 +05:30 • committed by GitHub
commit d42e5be4da
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/website/doctype/personal_data_deletion_request/personal_data_deletion_request.py
View file

@ -7,6 +7,7 @@ import re
import frappe
from frappe import _
from frappe.core.utils import find
from frappe.desk.doctype.notification_settings.notification_settings import is_email_notifications_enabled
from frappe.model.document import Document
from frappe.utils import get_datetime, get_fullname, time_diff_in_hours
from frappe.utils.user import get_system_managers
@ -101,10 +102,13 @@ class PersonalDataDeletionRequest(Document):
)
def notify_system_managers(self):
system_managers = get_system_managers(only_name=True)
recipients = []
for manager in get_system_managers(only_name=True):
if is_email_notifications_enabled(manager):
recipients.append(manager)
frappe.sendmail(
recipients=system_managers,
recipients=recipients,
subject=_("User {0} has requested for data deletion").format(self.email),
template="data_deletion_approval",
args={"user": self.email, "url": frappe.utils.get_url(self.get_url())},