Merge pull request #19391 from shariquerik/cmd/ctrl-to-see-fieldname

This commit is contained in:
Shariq Ansari 2022-12-26 16:32:46 +05:30 committed by GitHub
commit dc8aad9bbd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 38 additions and 6 deletions

View file

@ -2,12 +2,6 @@ frappe.ui.form.Control = class BaseControl {
constructor(opts) {
$.extend(this, opts);
this.make();
// if developer_mode=1, show fieldname as tooltip
if (frappe.boot.user && frappe.boot.developer_mode === 1 && this.$wrapper) {
this.$wrapper.attr("title", __(this.df.fieldname));
}
if (this.render_input) {
this.refresh();
}
@ -19,6 +13,7 @@ frappe.ui.form.Control = class BaseControl {
.attr("data-fieldname", this.df.fieldname);
this.wrapper = this.$wrapper.get(0);
this.wrapper.fieldobj = this; // reference for event handlers
this.$wrapper.append(`<span class="tooltip-content">${__(this.df.fieldname)}</span>`);
}
make_wrapper() {

View file

@ -35,6 +35,7 @@ frappe.ui.form.Layout = class Layout {
}
this.setup_tab_events();
this.setup_tooltip_events();
this.render();
}
@ -529,6 +530,19 @@ frappe.ui.form.Layout = class Layout {
});
}
setup_tooltip_events() {
$(document).on("keydown", (e) => {
if (e.metaKey || e.ctrlKey) {
this.wrapper.addClass("show-tooltip");
}
});
$(document).on("keyup", (e) => {
if (!e.metaKey || !e.ctrlKey) {
this.wrapper.removeClass("show-tooltip");
}
});
}
handle_tab(doctype, fieldname, shift) {
let grid_row = null,
prev = null,

View file

@ -1,6 +1,29 @@
@import "../common/form.scss";
@import '~cropperjs/dist/cropper.min';
.tooltip-content {
position: absolute;
bottom: 104%;
left: 0;
z-index: 9999;
padding: 2px 6px;
border-radius: var(--border-radius-sm);
background: var(--gray-dark);
color: var(--text-dark);
font-size: var(--text-xs);
opacity: 0;
cursor: default;
transition: opacity 0.3s, transform 3s;
pointer-events: none;
}
.show-tooltip .frappe-control:hover .tooltip-content {
opacity: 1;
transform: translate3d(0,0,0);
pointer-events: auto;
}
.std-form-layout > .form-layout > .form-page {
border-radius: var(--border-radius-md);
box-shadow: var(--card-shadow);