vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: sidebar item reference bug breaking addClass and removeClass (#10744)

Browse source
This commit is contained in:
Shivam Mishra 2020-06-19 11:30:32 +00:00 • committed by GitHub
parent 25928c6412
commit df0c96eba3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frappe/public/js/frappe/views/desktop/desktop.js
View file

@ -3,6 +3,7 @@ export default class Desktop {
this.wrapper = wrapper;
this.pages = {};
this.sidebar_items = {};
this.mobile_sidebar_items = {};
this.sidebar_categories = [
"Modules",
"Domains",
@ -84,10 +85,13 @@ export default class Desktop {
this.current_page = item.name;
}
let $item = get_sidebar_item(item);
$item.appendTo(this.mobile_list);
$item.clone().appendTo(this.sidebar);
let $mobile_item = $item.clone();
$item.appendTo(this.sidebar);
this.sidebar_items[item.name] = $item;
$mobile_item.appendTo(this.mobile_list);
this.mobile_sidebar_items[item.name] = $mobile_item;
};
const make_category_title = name => {
@ -122,7 +126,10 @@ export default class Desktop {
if (this.sidebar_items && this.sidebar_items[this.current_page]) {
this.sidebar_items[this.current_page].removeClass("selected");
this.mobile_sidebar_items[this.current_page].removeClass("selected");
this.sidebar_items[page].addClass("selected");
this.mobile_sidebar_items[page].addClass("selected");
}
this.current_page = page;
this.mobile_list.hide();