vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: reduce DB call in frappe.client.get (#17665)

Browse source
This commit is contained in:
Sagar Vora 2022-08-02 10:08:39 +00:00 • committed by GitHub
parent 2d1fe02dba
commit ebb0cd13fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frappe/client.py
View file

@ -78,16 +78,9 @@ def get(doctype, name=None, filters=None, parent=None):
if frappe.is_table(doctype):
check_parent_permission(parent, doctype)
if filters and not name:
name = frappe.db.get_value(doctype, frappe.parse_json(filters))
if not name:
frappe.throw(_("No document found for given filters"))
doc = frappe.get_doc(doctype, name)
if not doc.has_permission("read"):
raise frappe.PermissionError
return frappe.get_doc(doctype, name).as_dict()
doc = frappe.get_doc(doctype, name or frappe.parse_json(filters))
doc.check_permission()
return doc.as_dict()
@frappe.whitelist()
@ -144,8 +137,8 @@ def get_value(doctype, fieldname, filters=None, as_dict=True, debug=False, paren
def get_single_value(doctype, field):
if not frappe.has_permission(doctype):
frappe.throw(_("No permission for {0}").format(_(doctype)), frappe.PermissionError)
value = frappe.db.get_single_value(doctype, field)
return value
return frappe.db.get_single_value(doctype, field)
@frappe.whitelist(methods=["POST", "PUT"])