vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor!: remove unused parameter from rebuild_tree, add type hints (#24123)

Browse source 
* refactor!: remove unused parameter from rebuild_tree, add type hints

* fix: remove parent_field parameter from backend calls
This commit is contained in:
Raffael Meyer 2024-01-04 13:43:12 +01:00 • committed by GitHub
parent 6acbdbfc97
commit edac879d7e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/tests/test_nestedset.py
View file

@ -145,7 +145,7 @@ class TestNestedSet(FrappeTestCase):
leaf_node.reload()
def test_rebuild_tree(self):
rebuild_tree(TEST_DOCTYPE, "parent_test_tree_doctype")
rebuild_tree(TEST_DOCTYPE)
self.test_basic_tree()
def test_move_group_into_another(self):

10
frappe/utils/nestedset.py
View file

@ -168,12 +168,8 @@ def update_move_node(doc: Document, parent_field: str):
@frappe.whitelist()
def rebuild_tree(doctype, parent_field=None):
"""Call rebuild_node for all root nodes.
The `parent_field` parameter is ignored and will be removed in v16+ (kept for backward compatibility).
"""
def rebuild_tree(doctype: str) -> None:
"""Call rebuild_node for all root nodes."""
# Check for perm if called from client-side
if frappe.request and frappe.local.form_dict.cmd == "rebuild_tree":
frappe.only_for("System Manager")
@ -330,7 +326,7 @@ class NestedSet(Document):
)
if merge:
rebuild_tree(self.doctype, parent_field)
rebuild_tree(self.doctype)
def validate_one_root(self):
if not self.get(self.nsm_parent_field):