fix: delete user mention cache when a user is disabled or enabled (#17451)

User Mention cache is deleted on 3 occasions:

* when a new user is inserted
* when allowed_in_mention or user_type value has changed
* when a user is deleted

But we didn't delete it when a user was enabled or disabled as we maintain the mention cache for enabled users
This commit is contained in:
Ritwik Puri 2022-07-12 18:58:07 +05:30 committed by GitHub
parent ca39cfb11d
commit fbb89bdfe9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -134,11 +134,11 @@ class User(Document):
if self.time_zone:
frappe.defaults.set_default("time_zone", self.time_zone, self.name)
if self.has_value_changed("allow_in_mentions") or self.has_value_changed("user_type"):
frappe.cache().delete_key("users_for_mentions")
if self.has_value_changed("enabled"):
frappe.cache().delete_key("users_for_mentions")
frappe.cache().delete_key("enabled_users")
elif self.has_value_changed("allow_in_mentions") or self.has_value_changed("user_type"):
frappe.cache().delete_key("users_for_mentions")
def has_website_permission(self, ptype, user, verbose=False):
"""Returns true if current user is the session user"""