fix(client.py): fix get_value for name

This commit is contained in:
Rushabh Mehta 2020-08-21 15:14:59 +05:30
parent 1a50b594dd
commit ffa785bb47
2 changed files with 6 additions and 0 deletions

View file

@ -73,6 +73,8 @@ def get_value(doctype, fieldname, filters=None, as_dict=True, debug=False, paren
frappe.throw(_("No permission for {0}").format(doctype), frappe.PermissionError)
filters = get_safe_filters(filters)
if isinstance(filters, string_types):
filters = {"name": filters}
try:
fields = json.loads(fieldname)

View file

@ -67,6 +67,10 @@ class TestAPI(unittest.TestCase):
{"doctype": "Note", "public": True, "title": "get_value", "content": test_content},
])
self.assertEqual(server.get_value("Note", "content", {"title": "get_value"}).get('content'), test_content)
name = server.get_value("Note", "name", {"title": "get_value"}).get('name')
# test by name
self.assertEqual(server.get_value("Note", "content", name).get('content'), test_content)
self.assertRaises(FrappeException, server.get_value, "Note", "(select (password) from(__Auth) order by name desc limit 1)", {"title": "get_value"})