Commit graph

817 commits

Author SHA1 Message Date
gavin
d285ce910f
Merge branch 'develop' into mariadb-client-refactor 2022-07-22 12:11:54 +05:30
Ankush Menat
5ea96ced3a test: undo/redo, jump to field UI tests 2022-07-20 21:44:48 +05:30
Gavin D'souza
1ccdad811a Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor 2022-07-19 16:23:24 +05:30
Shariq Ansari
a50e0ffa08
refactor: Webform (#17232) 2022-07-19 15:52:15 +05:30
Ankush Menat
e762fe9ce1
test: clear filters on ToDo before running test (#17494) 2022-07-13 12:29:41 +05:30
Ankush Menat
d04df394a5 test: check for uploaded file to be private 2022-07-08 11:06:49 +05:30
gavin
43f378d848
Merge branch 'develop' into mariadb-client-refactor 2022-07-07 16:00:38 +05:30
Shariq Ansari
15018b96fa
test: fixed flaky workspace blocks UI test (#17436) 2022-07-07 14:53:25 +05:30
Ankush Menat
786d52f6f9 chore: disable recorder UI test 2022-06-27 17:32:57 +05:30
Ankush Menat
e63e26890c fix: show "doc modifed after" load message 2022-06-21 20:25:54 +05:30
Ankush Menat
9c5d6feec1
test(cypress): show full response on insert_doc failure (#17257) 2022-06-21 13:30:39 +05:30
Ankush Menat
6350406305
perf: remove duplicate control assets (#17237)
* test: flaky tests due to uncleared filters

* perf: remove duplicate code in assets

Remove controls which are separately bundled too, saves ~1.1MB of
network transfer.

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2022-06-20 14:28:38 +05:30
Ankush Menat
54824071c2 test: simple test for URL routing with params 2022-06-17 20:47:55 +05:30
Shariq Ansari
d9e848ef88 test: added UI test for date range control 2022-06-16 13:00:34 +05:30
Abhirup Pal
8c8249894b
fix: Update label for editing in full page and add custom logic for rendering it. (#17149) 2022-06-13 16:41:43 +05:30
Ankush Menat
03f48580ef test: button with single quote in label 2022-06-12 16:24:39 +05:30
Shariq Ansari
e740ad180d
test: fix for failing Data Control UI test (#17133) 2022-06-10 15:46:50 +05:30
Rushabh Mehta
7a1d5e304c
Merge pull request #17108 from rmehta/custom-formatters
feat(minor): add custom formatters for text type controls
2022-06-09 17:16:49 +05:30
gavin
fc9308f8ba
fix: Use same labels for standard fields throughout interfaces (#17031)
* fix(model)!: Match labels in meta & model

Labels for fields have been inconsistent. In standard filters, doc.name
would be labelled as "Name" while it's "ID" in the edit filters option.
Similarly for other fields, the same view will address the same fields
differently. This PR aims to get rid of such inconsistencies.

Changes:

* [model] Change label ID for name to 'Name'
* [meta] Match labels of owner, modified, modified_by
* [meta] Add labels for more fields - from model.js

* fix!: get_label to fetch labels as Desk does

* fix!(label): Refer to name field as 'ID' over 'Name'

* test: Use 'ID' label instead of 'Name'
2022-06-09 15:34:57 +05:30
Rushabh Mehta
e66cd830fb fix(minor): test + tabs 2022-06-09 14:17:43 +05:30
Rushabh Mehta
da9ac52ffb fix(minor): lint 2022-06-09 12:44:47 +05:30
Rushabh Mehta
e790b5e8b1 fix(minor): added UI test 2022-06-09 12:34:09 +05:30
Rushabh Mehta
378b44a382 fix(minor): fix flaky test 2022-06-09 12:07:04 +05:30
Shariq Ansari
b44235587f
test: fixed failing UI test (#16958) 2022-05-24 13:17:21 +05:30
Ankush Menat
fe8520a2bd
fix: duplicate buttons on desk (#16941) 2022-05-23 12:39:01 +05:30
Shariq Ansari
3a2cd2650e test: fixed failing UI test 2022-05-19 15:00:54 +05:30
Shariq Ansari
176518ed2c
fix: Mandatory field bad UX (#16919)
Mandatory fields are highlighted red on page load. It should only highlight if we save the document.

**Before:** Form

https://user-images.githubusercontent.com/30859809/168791201-049c1de2-b7f5-4dff-bf40-093ff96d4510.mov

**After:** Form

https://user-images.githubusercontent.com/30859809/168791164-45e2289b-2d2c-4ebb-8b4d-cd2932140572.mov

**Before:** Dialog

https://user-images.githubusercontent.com/30859809/168791207-800ba9e5-b4eb-419f-8a99-f94916c21c79.mov

**After:** Dialog

https://user-images.githubusercontent.com/30859809/168791210-f2761d23-3a60-40c2-8aff-2d2cebbd77fa.mov

Resolves https://github.com/frappe/frappe/issues/16866
2022-05-18 09:57:49 +00:00
Komal-Saraf0609
fea45bf341
test: Added test script for control type "Color" (#16619) 2022-05-17 12:40:37 +05:30
Himanshu
70409a3c7b
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour

### Behaviour

- Link field loses focus: show the translated name.
- Link field is focused
    - If old value is present
        - If options **are** one of [Role, DocType]: show the translated name
        - Else: show the name (untranslated) to enable search in untranslated values
    - Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus

## Demo

### Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

#### Before

https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov

#### After

https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov

### Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

#### Before

https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov

#### After

https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
2022-05-16 13:21:42 +00:00
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace (#16887) 2022-05-13 15:34:35 +05:30
Suraj Shetty
4be5ca6481 Merge branch 'develop' of https://github.com/frappe/frappe into fix-ui-flaky-tests 2022-05-05 19:28:00 +05:30
Suraj Shetty
aac9378beb
test: Disable flaky test
Unable to find the cause of the flakiness of the test. Disabling it for now.

Also, the form_tour test is full of `wait` which is bad anyway.
2022-05-05 18:37:08 +05:30
Suraj Shetty
bec77dba0d test: Fix flaky tests
Disable form tour tests
2022-04-28 19:32:43 +05:30
Rushabh Mehta
a59e5d7aac
Merge pull request #16791 from rmehta/fix-control-test
test: Fixes `control_dynamic_link` test
2022-04-28 16:05:05 +05:30
Rushabh Mehta
dfeb16f58d fix(test): control_dynamic_link.js 2022-04-28 15:20:29 +05:30
Rushabh Mehta
c23cc52948 fix(test): control_dynamic_link.js 2022-04-28 15:17:56 +05:30
gavin
f1cceba81b
Merge pull request #16763 from surajshetty3416/fix-autoname-validation
fix: Validate "autoname" for Customize Form
2022-04-28 15:03:39 +05:30
Suraj Shetty
532e5dd0d6
Merge pull request #16620 from Komal-Saraf0609/control-data 2022-04-28 15:02:50 +05:30
Rushabh Mehta
9847019457 fix(test): control_dynamic_link.js 2022-04-28 14:47:07 +05:30
Rushabh Mehta
efd993cdc3 fix(test): control_dynamic_link.js 2022-04-28 14:45:27 +05:30
Rushabh Mehta
ec2c65f0a5 fix(test): control_dynamic_link.js 2022-04-28 14:27:46 +05:30
Komal-Saraf0609
03efa25d03 test: Corrected failed tests 2022-04-28 12:06:45 +05:30
Suraj Shetty
30440026db fix: Do not allow autoname changes to/from autoincrement in customize form 2022-04-28 11:44:33 +05:30
Suraj Shetty
ccc82e2c4c
Merge pull request #15538 from noahjacob/phone_field_control
feat: Phone Control Type
2022-04-28 10:27:52 +05:30
Suraj Shetty
2f2fc0440d test: Init UI test for customize form 2022-04-27 15:56:20 +05:30
Suraj Shetty
bad4c38fd2
Merge branch 'develop' into control-data 2022-04-25 16:18:04 +05:30
Suraj Shetty
eb92acfbf3
Merge pull request #16718 from shariquerik/flaky-ui-test-3 2022-04-25 11:15:29 +05:30
Shariq Ansari
042f98bcc5
fix: Workspace Miscellaneous fixes (#16578) 2022-04-22 18:00:44 +05:30
Shariq Ansari
d558f16e71 test: fixed flaky test for form, timeline_email 2022-04-22 17:43:20 +05:30
Shariq Ansari
09a0077079 style: fixed indentation 2022-04-22 17:13:46 +05:30