Commit graph

44369 commits

Author SHA1 Message Date
hyaray
04a1e46ca4
fix: auto fetch module on report
* Update report.json

* fix: fetch only if empty

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-03 12:02:20 +05:30
Bernd Oliver Sünderhauf
bc4248fde8
test: Make control_phone UI test idempotent and a bit more reliable. (#23569)
* test(control_phone.js): Add a little waiting time before switching country.

* test(control_phone.js): Harden by removing fuzzy 'force' and 'multiple' qualifiers.

* test(control_phone.js): Make idempotent by removing dialog even after failure.
2023-12-03 11:56:46 +05:30
Bernd Oliver Sünderhauf
8fea592f00
chore: Fix codestyle issue from #23557. (#23567) 2023-12-03 09:25:31 +05:30
Ankush Menat
0803a66d06
Merge pull request #23565 from ankush/revert_oauth_routing
Revert "refactor: OAuth flow without breaking routing convention"
2023-12-02 20:25:54 +05:30
Corin Wenger
db315385d3
fix: Move SMS Log module from ERPNext to Frappe (#23557)
SMS Log module moved to Frappe Core from ERPNext Utilities so that Frappe send_sms() works sans-ERPNext.
2023-12-02 20:20:12 +05:30
Ankush Menat
6cb425baae Revert "refactor: OAuth flow without breaking routing convention"
This reverts commit e96ecab00e.
2023-12-02 20:02:24 +05:30
Ankush Menat
1ef44c90e2
Merge pull request #23320 from HarryPaulo/fix-translation-file-path
fix: load languages that have capital letters
2023-12-02 19:58:15 +05:30
Bernd Oliver Sünderhauf
a8e0ea3109 test: Add failing tests for language variant precedence. 2023-12-02 19:57:43 +05:30
Raffael Meyer
3198b4f490
feat(DX): button "Pull Emails" (#23553) 2023-12-02 13:04:01 +05:30
Corentin Flr
6f36c0fa0b
fix(form_builder): Use locale-aware sorting and search for fieldtypes (#23454)
* fix(form_builder): Use locale-aware string sort and search for DocFields

* fix(form_builder): Fix CSS cursor for DocField autocomplete
2023-12-01 21:39:52 +05:30
Raffael Meyer
668b3c0026
refactor: store reference to leaflet draw control (#23233)
Enables easier customization of draw controls.
2023-12-01 21:26:57 +05:30
Raffael Meyer
70770958f6
fix: quicklist (#23548)
* fix: stringify object instead of trying to parse

* fix: more appropriate label

"Set" is already occupied in filters as ["is", "Set"],
referring to a state, while here it is an action.
2023-12-01 21:10:57 +05:30
Ankush Menat
cbd61b4827
fix(UX): Add group by information in report view URLs (#23547)
* fix: support group by in report view URL

* fix: store sort field and order in URL

* Revert "fix: store sort field and order in URL"

This reverts commit 4cb65f8ccdccf7c4eebdc551e20534b28e53cc7b.
2023-12-01 20:56:23 +05:30
Shariq Ansari
75c3b7d1d7
test: skip permissions.js UI test
To check if it is the reason for test are failing frequently
2023-12-01 20:38:40 +05:30
Shariq Ansari
da385ccefe
Merge pull request #23537 from shariquerik/flaky-ui-test 2023-12-01 20:21:20 +05:30
Shariq Ansari
33f729ebd3 chore: linter fix 2023-12-01 20:03:18 +05:30
Shariq Ansari
856beca884
Merge pull request #23520 from niraj2477/feat/subject-in-timeline-mail 2023-12-01 20:01:30 +05:30
Shariq Ansari
78e63be26d
chore: linter fix 2023-12-01 19:37:55 +05:30
Shariq Ansari
a703bf398d
chore: linter fix 2023-12-01 19:37:09 +05:30
14987
77da425169
fix(UI): Display timestamp beside name 2023-12-01 19:22:44 +05:30
Bernd Oliver Sünderhauf
3bf0d08dc7
fix: Preserve title case in String.prototype.plural. (#23465) 2023-12-01 19:18:21 +05:30
14987
44a0bef8c9
fix: Update the css 2023-12-01 18:51:13 +05:30
14987
f027034404
fix: Update subject display location 2023-12-01 17:14:39 +05:30
Ankush Menat
1e20820846
refactor: Indicate that weak hash functions are not usedforsecurity (#23540)
[skip ci]
2023-12-01 16:04:37 +05:30
mergify[bot]
e2c168a6e0
Merge pull request #23442 from ruthra-kumar/webhooks_refactor
refactor: execute last instance of webhook trigger on documents
2023-12-01 10:02:04 +00:00
ruthra kumar
0a7c0593da refactor: execute the last instance of a webhook in a request 2023-12-01 15:15:43 +05:30
Shariq Ansari
8c2ef311bb test: flaky multi_select_dialog 2023-12-01 15:02:06 +05:30
Shariq Ansari
b2f8c11330 test: flaky control_link 2023-12-01 15:01:54 +05:30
Ankush Menat
ddedfd1d9e
build: pin editor js (#23534) 2023-12-01 13:18:33 +05:30
dependabot[bot]
821b469ff3
build(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2 (#23532)
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-01 12:12:12 +05:30
Ankush Menat
71e31a4200 chore: version bump 2023-12-01 10:36:49 +05:30
tonspar
fae3685b03
feat: Patch and Delete Request to integration utils (#23525)
* Update utils.py

Adding the patch and delete request

* Update safe_exec.py

Adding the patch and delete request from integration utils.
2023-12-01 10:25:43 +05:30
Ankush Menat
7b46223b76
Merge pull request #23521 from frappe/fix-readonly-edit
fix: prevent edit of readonly popup fields
2023-11-30 19:45:39 +05:30
Ankush Menat
c24a1d1b43
Merge pull request #23483 from akhilnarang/sentry
feat: Sentry support to automatically catch and report errors (opt-in)
2023-11-30 19:28:26 +05:30
18alantom
4a0562af3e fix: prevent edit of readonly popup fields 2023-11-30 19:17:27 +05:30
Ankush Menat
0e8b4de96f fix: tweak sentry config
- disable session tracking - This causes sentry to phone home on every load, we don't need this (yet)
- disable automatic integrtaions (like redis)
- disable all default integration and cherry-pick what's required
2023-11-30 19:01:19 +05:30
Ankush Menat
52686f79cb refactor: code cleanup
- better boot config name
- send sentry after - because frappe namespce doesn't exist if it starts
  first
- remove import in app.py because __init__ is always imported so no
  need.
- leave telemetry JS always present, this is used even when telemetry is
  not enabled.
2023-11-30 17:40:53 +05:30
14987
10823a6c96
feat(UI): Add subject in timeline communication 2023-11-30 17:36:49 +05:30
Ankush Menat
4cc1392697 ci: report all errors to sentry
This can be useful.
2023-11-30 17:34:15 +05:30
Akhil Narang
2bab0ab309 fix(js): use the correct field for sentry DSN
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Akhil Narang
9a0a5468c5 feat: setup sentry integration
Inspired primarily from sentry's generic WSGI integration

Environment variable `FRAPPE_SENTRY_DSN` needs to be enabled as well
as explicit opt-in from the user's side in system sid telemetry
settings

Conditionally include telemetry JS bundles

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Ankush Menat
a7137bdeaa feat: client side error reporting + sentry
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Ankush Menat
cccb95387c build(deps): add sentry/browser dependency 2023-11-30 17:13:41 +05:30
Ankush Menat
ebbd3cd137
fix: skip overriden doctypes during orphan check (#23518)
These are prone to breakage and shouldn't be deleted automatically.

This mostly works fine but there can be cases where it doesn't. So best to leave them untouched.
2023-11-30 11:33:42 +00:00
Ankush Menat
286e0a7b96
fix: Always evaluate Virtual Fields (#23515)
Related: https://github.com/frappe/frappe/issues/23475
Likely caused by: https://github.com/frappe/frappe/pull/22110

Because run_doc_method passes doc from client to server side, we end up
setting values for what is a "virtual field", this is why it finds some
value and not re-evaluate it.

IMO there are only mild breaking ways of fixing this:
1. Virtual fields should always be computed.
2. Virtual fields should not be set when init-ing the arguement. (e.g. from doc.set APIs )
2023-11-30 16:22:22 +05:30
Raffael Meyer
8c9275ba4e
fix: add blank line after auto-generated types (#23430) 2023-11-30 13:22:28 +05:30
Ankush Menat
c23771475c
refactor: Use hooks to specify default log clearing (#23507) 2023-11-30 13:06:29 +05:30
Abdo Hamoud
ba1d597e73
fix: image cropper in RTL mode (#23492) 2023-11-30 11:13:11 +05:30
Lucas Z
92684ab029
Update de.csv (#23478) 2023-11-30 00:21:31 +05:30
Raffael Meyer
7e08f003b3
fix: translate customize form (german) (#23497)
* fix: show translated doctype names

* fix: german translations for customize form
2023-11-30 00:18:52 +05:30